Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github build actions on Linux failing due to Node16 runner removal #4064

Merged
merged 34 commits into from
Dec 2, 2024

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Nov 28, 2024

Fixes #4068

Node16 has been removed from the github runners causing dependent actions to fail see actions/checkout#1590

Workaround to be able to build within centos7 image is to start within docker rather than use a github action "container" setup

Signed-off-by: Andrew Leonard <[email protected]>
@andrew-m-leonard andrew-m-leonard self-assigned this Nov 28, 2024
Signed-off-by: Andrew Leonard <[email protected]>
@andrew-m-leonard andrew-m-leonard marked this pull request as draft November 28, 2024 13:27
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
@github-actions github-actions bot added the docker Issues related to our docker files and docker scripts label Nov 28, 2024
@andrew-m-leonard andrew-m-leonard changed the title PR TEST github build actions on Linux failing due to Node16 runner removal Nov 28, 2024
@andrew-m-leonard andrew-m-leonard marked this pull request as ready for review December 2, 2024 09:23
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@adamfarley adamfarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-m-leonard andrew-m-leonard merged commit ed07fcf into adoptium:master Dec 2, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Issues related to our docker files and docker scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

temurin-build Linux Build PR CI checks are all failing due to github runner removal of Node16 support
3 participants