Revert "Temporarily change jdk8 openj9 back to using vs2010 (#2227)" #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#2227)" This reverts commit 5ba48d9 and reinstates adoptium#2191
sxa
added
enhancement
|
I don't see any Windows build in the recent nightlies to look at. I believe the VS2010 builds continue to work as long as they can find msvcp100.dll on the machines. The builds are configured to include msvcp120.dll into the build. |
|
Downloaded a recent nightly from Jenkins. There is no msvcp dll included in the build. In working builds for VS2013 (such as the Nov 10th build found via the Adopt website), msvcp120.dll is included. |
|
Thanks for the update - we'll put it back up to VS2013 as soon as this PR has approval again. Just surprised me to find that it seemed to still be working with 2010 :-) |
M-Davies
approved these changes
Nov 24, 2020
|
Will not be merging this until #2255 is resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reinstantes #2191.
Interestingly we reverted this to do 8u272-b01 but it didn't break the OpenJ9 nightlies, which suggests it may not be as tightly coupled to the other PRs as was initially suggested via #2191 (comment)
FYI @pshipton since we've been buiding with 2010 again for the last week or so