fix: Prevent use of docker builder cache for installer builds #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdams
approved these changes
Feb 22, 2023
smlambert
approved these changes
Feb 22, 2023
zdtsw
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #611
During the installer/packaging builds the signing steps although designated to run, were not picking up the GPG_KEY, after some investigation, this is because of issues utilising the docker build-cache. The change to the gradle files, disables this docker feature, ensuring that the docker images/containers are built cleanly each time without the use of cache. This does not add any significant overhead to the build time in jenkins.
Test runs in jenkins linked below 👍
https://ci.adoptium.net/job/adoptium-packages-linux-pipeline_new/267/
https://ci.adoptium.net/job/adoptium-packages-linux-pipeline_new/266/
https://ci.adoptium.net/job/adoptium-packages-linux-pipeline_new/266/
https://ci.adoptium.net/job/adoptium-packages-linux-pipeline_new/265/