Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install xvfb on headless (linux) machines #184

Closed
smlambert opened this issue Feb 7, 2018 · 9 comments · Fixed by #225
Closed

Install xvfb on headless (linux) machines #184

smlambert opened this issue Feb 7, 2018 · 9 comments · Fixed by #225

Comments

@smlambert
Copy link
Contributor

  1. install xvfb
    Much like the jck machines have xvfb installed (https://github.com/AdoptOpenJDK/openjdk-infrastructure/blob/master/ansible/playbooks/ubuntu-jck.yml#L26), we need it to be installed on all machines.

  2. remove other x11 configuration
    The other x11 server setup that is currently being done in the playbooks (https://github.com/AdoptOpenJDK/openjdk-infrastructure/blob/master/ansible/playbooks/AdoptOpenJDK_Linux_Playbook/roles/x11/tasks/main.yml) is likely not needed, unless you know of someone else using them.

It is not required to start the display as the ubuntu-jck playbook does, as we can/should control that from the Jenkinsfile.

More details on this approach (suggested by @tellison): adoptium/aqa-tests#49 (comment)

@sxa
Copy link
Member

sxa commented Feb 8, 2018

Mac will require a different solution as I understand it. @gdams has my issue to do it for the JCK boxes (our first attempt didn't work properly) but if anyone else has experience of sensible ways of doing this they're welcome to volunteer ;-)

@sxa
Copy link
Member

sxa commented Feb 13, 2018

@smlambert Do the other X packages explicitly need to be removed from the existing boxes? Or are you just asking for them to be removed from the playbook as they're not required to your knowledge?

@smlambert
Copy link
Contributor Author

smlambert commented Feb 13, 2018

I do not believe they need to be removed from the machine/playbook (as in I don't think they interfere with the xvfb solution, though I do not have a machine to confirm that on). I mentioned it only as a code hygiene suggestion, since I am not aware of anyone who needs/depends on them.

@smlambert smlambert changed the title Install xvfb on headless (linux / mac) machines Install xvfb on headless (linux) machines Feb 15, 2018
@geraintwjones
Copy link
Contributor

What is the relationship between this issue and #217?

@sxa
Copy link
Member

sxa commented Feb 19, 2018

@geraintwjones Other than the query over whether it's necessary to remove any existing packages #217 (comment) there's no significant difference - the other one specifically references the playbook, I suppose you could consider this one "executing the playbook to resolve Shelley's issue" they're

@geraintwjones
Copy link
Contributor

geraintwjones commented Feb 20, 2018

Someone's already added xorg-x11-server-Xvfb for RedHat and xvfb for Ubuntu.
Of the platforms we've currently defined packages for, that leaves...

  • CentOS
  • FreeBSD
  • OracleLinux
  • SLES

I can only currently test packages on CentOS and SLES, so I'll focus on those first.

@geraintwjones
Copy link
Contributor

So all playbooks modified, and changes merged. Now need to run them.

@karianna
Copy link
Contributor

karianna commented Jun 5, 2018

@geraintwjones Can this be closed now?

@sxa
Copy link
Member

sxa commented Jun 28, 2018

I reckon so, therefore closing :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants