WIP Add X11 setup and DISPLAY settings #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is blocked by adoptium/infrastructure#184 |
|
@smlambert Also merge conflicts. |
|
I will resolve the merge conflicts, but this is a WIP that can not be merged until the infra issue is addressed. |
terryzuoty
reviewed
Feb 27, 2018
| @@ -74,7 +74,9 @@ pipeline { | |||
| withEnv(["JAVA_HOME=$WORKSPACE/openjdkbinary/j2sdk-image/${(params.JAVA_VERSION == 'SE80') ? 'jre/' : ''}", | |||
| "JAVA_BIN=$WORKSPACE/openjdkbinary/j2sdk-image/${(params.JAVA_VERSION == 'SE80') ? 'jre/' : ''}bin", | |||
| "JAVA_VERSION=${params.JAVA_VERSION}"]) { | |||
| sh "$OPENJDK_TEST/maketest.sh $OPENJDK_TEST ${params.TARGET}" | |||
| wrap([$class: 'Xvfb']) { | |||
There was a problem hiding this comment.
since we are using DISPLAY=:1, we need to tell Xvfb to set display name to :1.
This would be like wrap([$class: 'Xvfb', displayName: 1]) {
|
@ShelleyLambert Was something else merged in instead? |
|
I guess I deleted an old branch and did not look to see this was still pending (and that the infra issue it was depending on has now been closed). I will revive it, in a new branch/PR and see if we are able to run the jdk_awt and jdk_swing tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires updates to Jenkinsfiles (for xvfb plugin), to playlists (for DISPLAY settings), and to exclude files to reinclude tests that are excluded due to issue number #49