Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use jinja templating to remove distro specific cases in entrypoint.sh #616

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

gdams
Copy link
Member

@gdams gdams commented Jul 25, 2024

This change simplifies the logic in the entrypoint.sh script as well as adds the required copyright header to the files

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@gdams
Copy link
Member Author

gdams commented Jul 25, 2024

ping @rassie if you wouldn't mind reviewing this (you're by far the most familiar with this code)

11/jdk/alpine/entrypoint.sh Outdated Show resolved Hide resolved
@rassie
Copy link
Contributor

rassie commented Jul 26, 2024

I've only had a quick glance, but I think it's fine.

@karianna
Copy link
Contributor

/thaw

@github-actions github-actions bot dismissed their stale review July 28, 2024 00:43

Pull Request unblocked - code freeze is over.

@karianna karianna requested review from tianon and andrew-m-leonard and removed request for tianon and github-actions[bot] July 28, 2024 01:00
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks okay I think

@gdams gdams merged commit f4e2fe5 into adoptium:main Jul 29, 2024
77 checks passed
@gdams gdams deleted the simplify branch July 29, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants