Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sanity.external on JDK11 xlinux #263

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Mar 9, 2022

  • Enable sanity.external on JDK11 xlinux (weekly)
  • Set DYNAMIC_COMPILE to true for functional and external testing

Signed-off-by: lanxia [email protected]

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), I require an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.

@llxia
Copy link
Contributor Author

llxia commented Mar 9, 2022

@smlambert @sophia-guo please review. Thanks

- Enable sanity.external on JDK11 xlinux
- Set DYNAMIC_COMPILE to true for functional and external testing

Signed-off-by: lanxia <[email protected]>
@sophia-guo
Copy link
Contributor

This should be fine for sanity.external on JDK11 xlinux (weekly). Going forward we may enable sanity.external as nightly and extended.external as weekly for all linux and all version as default. In that case probably updating defaults.json is preferred.

@llxia
Copy link
Contributor Author

llxia commented Mar 9, 2022

Not sure if we should use defaults.json as not all platforms have docker support. We will need to evaluate per platform. I guess we can make the decision once we have more external tests running.

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @llxia !

@sophia-guo sophia-guo merged commit 04ce2de into adoptium:master Mar 9, 2022
llxia pushed a commit to llxia/ci-jenkins-pipelines that referenced this pull request Jan 8, 2025
Enable RERUN_FAILURE for nightly/weekly runs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants