-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable sanity.external on JDK11 xlinux #263
Conversation
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), I require an admin to post |
@smlambert @sophia-guo please review. Thanks |
- Enable sanity.external on JDK11 xlinux - Set DYNAMIC_COMPILE to true for functional and external testing Signed-off-by: lanxia <[email protected]>
This should be fine for sanity.external on JDK11 xlinux (weekly). Going forward we may enable sanity.external as nightly and extended.external as weekly for all linux and all version as default. In that case probably updating defaults.json is preferred. |
Not sure if we should use defaults.json as not all platforms have docker support. We will need to evaluate per platform. I guess we can make the decision once we have more external tests running. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @llxia !
Enable RERUN_FAILURE for nightly/weekly runs
Signed-off-by: lanxia [email protected]