Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Crytpo tests on z/OS for JDK21 #5522

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

psoujany
Copy link
Contributor

This PR is to disable openjdk crypto tests which are part of functional tests on z/OS for JDK21. These tests are already disabled on openj9.

@psoujany
Copy link
Contributor Author

Verified changes

Job : Grinder_CR/22004

TEST TARGETS SUMMARY
18:38:00 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
18:38:00 DISABLED test targets:
18:38:00 CryptoTests_0
18:38:00 CryptoTests_jtreg_0

Comment on lines 24 to 28
<disable>
<comment>https://github.com/eclipse-openj9/openj9/issues/16712</comment>
<version>21+</version>
<impl>ibm</impl>
</disable>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed as this target is disabled in general. See L43 - L46.
If it is enabled, it should inherit all the disable from CryptoTests_jtreg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @llxia , corrected my change.

@llxia llxia requested a review from LongyuZhang August 22, 2024 13:30
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit 8841176 into adoptium:master Aug 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants