Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checks in TAP file verification #5067

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Add checks in TAP file verification #5067

merged 1 commit into from
Feb 14, 2024

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Feb 14, 2024

resolves: #5060

@llxia
Copy link
Contributor Author

llxia commented Feb 14, 2024

image

@llxia
Copy link
Contributor Author

llxia commented Feb 14, 2024

image

@llxia
Copy link
Contributor Author

llxia commented Feb 14, 2024

image

@llxia llxia marked this pull request as ready for review February 14, 2024 20:30
smlambert
smlambert approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karianna karianna merged commit e8a46ae into adoptium:master Feb 14, 2024
1 check passed
@smlambert smlambert mentioned this pull request Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert approved these changes

@karianna karianna karianna approved these changes

@JasonFengJ9 JasonFengJ9 Awaiting requested review from JasonFengJ9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance TAP verification
3 participants
@llxia @karianna @smlambert