-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consume parameters dynamically in AQA Test Pipeline #5048
Conversation
70065d3
to
d7f83c0
Compare
This PR passes the parameters from AQA Test Pileine to its child jobs dynamically. It means we will not need to add specific code for setting/passing new parameters to child jobs moving forward. This will also allow AQA Test Pileine to trigger any kind of test build, including Grinder. A powerful use case could be to run specific test(s)/BUILD_LIST using specific releases (i.e., TOP_LEVEL_SDK_URL) on all platforms in Grinder. resolves: adoptium#5049 Signed-off-by: Lan Xia <[email protected]>
@sophia-guo This PR should not change any existing behavior. For due diligence, could you please ensure this change works in your environment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@llxia Fee free to merge once you've checked it works in your env. |
It works in our env. I am waiting for @sophia-guo to confirm. |
@sophia-guo This is your test build config issue. Please ensure LIGHT_WEIGHT_CHECKOUT is set to false and regen test build if you want to use my repo and branch. |
Couple of issues to test it in temurin-eclipse. The main issue is related LIGHT_WEIGHT_CHECKOUT, but also related with the rename openjdk_tests to aqa-tests. However the test should be good as long as child builds can be triggered with correct params ( no need to be succeed.) That is saying it works in temurin-eclipse. |
This PR passes the parameters from AQA Test Pileine to its child jobs dynamically.
It means we will not need to add specific code for setting/passing new parameters
to child jobs moving forward.
This will also allow AQA Test Pileine to trigger any kind of test build, including Grinder.
A powerful use case could be to run specific test(s)/BUILD_LIST using specific releases
(i.e., TOP_LEVEL_SDK_URL) on all platforms in Grinder.
resolves: #5049
Signed-off-by: Lan Xia [email protected]