Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consume parameters dynamically in AQA Test Pipeline #5048

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Feb 8, 2024

This PR passes the parameters from AQA Test Pileine to its child jobs dynamically.
It means we will not need to add specific code for setting/passing new parameters
to child jobs moving forward.
This will also allow AQA Test Pileine to trigger any kind of test build, including Grinder.
A powerful use case could be to run specific test(s)/BUILD_LIST using specific releases
(i.e., TOP_LEVEL_SDK_URL) on all platforms in Grinder.

resolves: #5049

Signed-off-by: Lan Xia [email protected]

@llxia llxia force-pushed the test9 branch 3 times, most recently from 70065d3 to d7f83c0 Compare February 8, 2024 15:15
This PR passes the parameters from AQA Test Pileine to its child jobs dynamically.
It means we will not need to add specific code for setting/passing new parameters
to child jobs moving forward.
This will also allow AQA Test Pileine to trigger any kind of test build, including Grinder.
A powerful use case could be to run specific test(s)/BUILD_LIST using specific releases
(i.e., TOP_LEVEL_SDK_URL) on all platforms in Grinder.

resolves: adoptium#5049

Signed-off-by: Lan Xia <[email protected]>
@llxia
Copy link
Contributor Author

llxia commented Feb 8, 2024

  • link
  • link
  • link => tests were executed as expected. The failure is not related to this PR.

@llxia llxia marked this pull request as ready for review February 8, 2024 15:49
@llxia llxia requested a review from sophia-guo February 8, 2024 15:49
@llxia
Copy link
Contributor Author

llxia commented Feb 8, 2024

@sophia-guo This PR should not change any existing behavior. For due diligence, could you please ensure this change works in your environment?

Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karianna
Copy link
Contributor

@llxia Fee free to merge once you've checked it works in your env.

@llxia
Copy link
Contributor Author

llxia commented Feb 12, 2024

It works in our env. I am waiting for @sophia-guo to confirm.

@sophia-guo
Copy link
Contributor

sophia-guo commented Feb 12, 2024

What's the best test case?
Screenshot 2024-02-12 at 10 04 52 AM

@llxia
Copy link
Contributor Author

llxia commented Feb 12, 2024

@sophia-guo This is your test build config issue. Please ensure LIGHT_WEIGHT_CHECKOUT is set to false and regen test build if you want to use my repo and branch.

@sophia-guo
Copy link
Contributor

Couple of issues to test it in temurin-eclipse. The main issue is related LIGHT_WEIGHT_CHECKOUT, but also related with the rename openjdk_tests to aqa-tests. However the test should be good as long as child builds can be triggered with correct params ( no need to be succeed.) That is saying it works in temurin-eclipse.

@LongyuZhang LongyuZhang merged commit b4c6b1d into adoptium:master Feb 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consume parameters dynamically in AQA Test Pipeline
4 participants