Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for FIPS140_3 #4906

Merged
merged 1 commit into from
Dec 6, 2023
Merged

add support for FIPS140_3 #4906

merged 1 commit into from
Dec 6, 2023

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Dec 6, 2023

related: backlog/issues/1188

@llxia
Copy link
Contributor Author

llxia commented Dec 6, 2023

Grinder => we do not have FIPS140-3 SDK yet. Aborted the Grinder (after 50 mins).

TEST_FLAG=FIPS140_3_OpenJcePlus

00:00:14.671  EXTRA_OPTIONS= -Dsemeru.fips=true -Dsemeru.customprofile=OpenJcePlus
00:01:29.196  ===============================================
00:01:29.196  Running test jdk_math_0 ...
00:01:29.196  ===============================================
00:01:29.196  jdk_math_0 Start Time: Wed Dec  6 08:59:29 2023 Epoch Time (ms): 1701881969344
00:01:29.196  variation: -Xdump:system:none -Xdump:heap:none -Xdump:system:events=gpf+abort+traceassert+corruptcache Mode150
00:01:29.196  JVM_OPTIONS:  -Xdump:system:none -Xdump:heap:none -Xdump:system:events=gpf+abort+traceassert+corruptcache -XX:+UseCompressedOops -Xverbosegclog  -Dsemeru.fips=true -Dsemeru.customprofile=OpenJcePlus

@llxia llxia marked this pull request as ready for review December 6, 2023 17:48
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JasonFengJ9
Copy link
Contributor

#4906 (comment)
The initial grinder has set TEST_FLAG to FIPS140_3_OpenJcePlus,CRIU, any reason for CRIU here?
Re-run it in another grinder

15:04:07      [javac] /home/jenkins/workspace/Grinder_FIPS/aqa-tests/TKG/src/org/testKitGen/TestDivider.java:242: error: cannot find symbol
15:04:07      [javac] 		} catch (IOException | ParseException e) {
15:04:07      [javac] 		                       ^
15:04:07      [javac]   symbol:   class ParseException
15:04:07      [javac]   location: class TestDivider
15:04:07      [javac] 17 errors

Maybe the PR needs a rebase?

@llxia
Copy link
Contributor Author

llxia commented Dec 6, 2023

The initial grinder has set TEST_FLAG to FIPS140_3_OpenJcePlus,CRIU, any reason for CRIU here?

CRIU is added by TKG automatically. This SDK has the CRIU feature enabled. This behavior is expected.

@JasonFengJ9
Copy link
Contributor

Tested an internal grinder.

@JasonFengJ9 JasonFengJ9 merged commit 51bc3c3 into adoptium:master Dec 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants