Fix portable aot tests #4894
Merged
Fix portable aot tests #4894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LongyuZhang
commented
Nov 30, 2023
•
LongyuZhang
commented
- Some pipelines have $DOCKER_REGISTRY_CREDENTIALS in jenkins-pipeline but not $BASE_DOCKER_REGISTRY_CREDENTIAL, in this case login is not needed.
- Related Issue: github_ibm/runtimes/backlog/issues/1262
- Some pipelines have $DOCKER_REGISTRY_CREDENTIALS in jenkins-pipeline but not $BASE_DOCKER_REGISTRY_CREDENTIAL, in this case login is not needed. Signed-off-by: LongyuZhang <[email protected]>
|
Test Links:
|
karianna
reviewed
Dec 12, 2023
external/external.sh
Outdated
| # Container credential check. Temporarily criu-ubi image with criu binary is only available internally | ||
| if [[ ! -z $BASE_DOCKER_REGISTRY_CREDENTIAL_USR || ! -z $DOCKER_REGISTRY_CREDENTIALS_USR ]]; then | ||
| # Container credential check. | ||
| # Temporarily criu-ubi image with criu binary is only available internally |
There was a problem hiding this comment.
This comment is a bit hard to read :-). Not quite sure what logic it is trying to convey.
There was a problem hiding this comment.
In this step, external tests get the initial base container image. Most tests uses BASE_DOCKER_REGISTRY_CREDENTIAL to get this base image from Dockerhub (this login will increase pull limit), but criu-ubi base image temporarily get its base image from hyc-dockerhub instead since we can only set up its dependent package internally with ubi subscription. Once we are able to publish this image on Dockerhub later, we will remove this logic then.
smlambert
reviewed
Dec 12, 2023
Co-authored-by: Shelley Lambert <[email protected]>
smlambert
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.