Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy getJtreg to shared location #4871

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Copy getJtreg to shared location #4871

merged 1 commit into from
Nov 23, 2023

Conversation

annaibm
Copy link
Contributor

@annaibm annaibm commented Nov 15, 2023 •
edited
Loading

-Moved the getJtreg download logic to TKG/scripts/getDependencies.xml

resolves : #4848

@annaibm
Copy link
Contributor Author

annaibm commented Nov 15, 2023

Grinder outputs:
openjdk: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36142/
Crypto test: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36150/
ssl-test:https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36151

llxia
llxia requested changes Nov 17, 2023
View reviewed changes
functional/security/Crypto/build.xml Outdated Show resolved Hide resolved
@annaibm
Copy link
Contributor Author

annaibm commented Nov 21, 2023 •
edited
Loading

Grinder outputs:
openjdk: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36330/
openjdk with hotspot: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36373/
Crypto test: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36331/
ssl-test:https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36332/

@annaibm annaibm requested a review from llxia November 21, 2023 20:41
llxia
llxia reviewed Nov 21, 2023
View reviewed changes
openjdk/openjdk.mk Outdated Show resolved Hide resolved
@llxia
Copy link
Contributor

llxia commented Nov 21, 2023 •
edited
Loading

Please squash the commits and run openjdk test with hotspot.

@annaibm annaibm force-pushed the move_getJtreg_4848 branch 3 times, most recently from 405eb54 to d197e2c Compare November 22, 2023 14:56
@annaibm
Copy link
Contributor Author

annaibm commented Nov 22, 2023

Grinder Tests:
openjdk with hotspot: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36373/

@annaibm annaibm requested a review from llxia November 22, 2023 16:53
@annaibm
Copy getJtreg to shared location
0e4e419 
-Moved the getJtreg tar download logic to TKG/scripts/getDependencies.xml

resolves : adoptium#4848

Signed-off-by: Anna Babu Palathingal <[email protected]>
@annaibm annaibm marked this pull request as ready for review November 22, 2023 20:42
@llxia
Copy link
Contributor

llxia commented Nov 22, 2023

openjdk: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36330/

Console output:

00:01:47.001  getJtregVersion:
00:01:47.001  
00:01:47.001  getDependentLibs:
00:01:47.001       [exec] --------------------------------------------
00:01:47.001       [exec] path is set to /home/jenkins/workspace/Grinder/aqa-tests/TKG/../TKG/lib
00:01:47.001       [exec] task is set to default
00:01:47.001       [exec] dependencyList is set to jtreg_7_3_1_1,tohandler_simple
00:01:47.001       [exec] --------------------------------------------
00:01:47.001       [exec] Starting download third party dependent jars
00:01:47.001       [exec] --------------------------------------------
00:01:47.001       [exec] downloading dependent third party jars to /home/jenkins/workspace/Grinder/aqa-tests/TKG/../TKG/lib
00:01:47.001       [exec] /home/jenkins/workspace/Grinder/aqa-tests/TKG/../TKG/lib/openj9jtregtimeouthandler.jar exists with correct hash, not downloading
00:01:47.001       [exec] /home/jenkins/workspace/Grinder/aqa-tests/TKG/../TKG/lib/jtreg_7_3_1_1.tar.gz exists with correct hash, not downloading
00:01:47.001       [exec] downloaded dependent third party jars successfully
00:01:47.001  
00:01:47.001  getJtreg:
00:01:47.001      [mkdir] Created dir: /home/jenkins/workspace/Grinder/jvmtest/openjdk
00:01:47.001       [copy] Copying 1 file to /home/jenkins/workspace/Grinder/aqa-tests/openjdk
00:01:47.449  
00:01:47.449  openjdk-jdk.check:

llxia
llxia approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia requested a review from smlambert November 22, 2023 21:13
@llxia
Copy link
Contributor

llxia commented Nov 22, 2023

This PR has to be merged together with adoptium/TKG#473

smlambert
smlambert approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TKG PR was merged earlier today, bringing this one in as they are related.

@smlambert smlambert merged commit 194e8b8 into adoptium:master Nov 23, 2023
9 of 26 checks passed
@annaibm annaibm deleted the move_getJtreg_4848 branch November 27, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia approved these changes

@smlambert smlambert smlambert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move getJtreg ant target to a shared location
3 participants
@annaibm @llxia @smlambert