Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to set docker info in AQA_Test_Pipeline #4748

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Allow users to set docker info in AQA_Test_Pipeline #4748

merged 1 commit into from
Oct 31, 2023

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Sep 6, 2023

resolves: #4747

@llxia llxia marked this pull request as ready for review October 30, 2023 18:42
@llxia
Copy link
Contributor Author

llxia commented Oct 30, 2023

AQA_Test_Pipeline/324/ ==> job failed due to reached your pull rate limit

LongyuZhang
LongyuZhang approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JasonFengJ9
Copy link
Contributor 

14:36:20  build_image:
14:36:20       [echo] Executing external.sh --build --dir criu-ubi-portable-checkpoint --tag nightly --version 11 --impl openj9 --base_docker_registry_dir 'ubi8-with-criu/linux_x86-64-ubi8-criu' --docker_registry_url docker-na.artifactory.swg-devops.com/sys-rt-docker-local --docker_args -v /home/jenkins/workspace/Test_openjdk11_j9_dev.external_x86-64_linux_imageUpload/openjdkbinary/j2sdk-image:/opt/java/openjdk 
14:36:20       [exec] The test here is criu-ubi-portable-checkpoint
14:36:20       [exec] The directory in the external.sh is criu-ubi-portable-checkpoint
14:36:20       [exec] DOCKERIMAGE_TAG nightly has been recognized.
14:36:20       [exec] Private Docker Registry login starts to obtain base Docker Image:
14:36:20       [exec] Error: Must provide --username with --password-stdin

docker_registry_url was supplied.
@llxia is this error expected?

@llxia
Copy link
Contributor Author

llxia commented Oct 31, 2023

Reran passed. dev.external related builds need to run with DYNAMIC_COMPILE=true.

JasonFengJ9
JasonFengJ9 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@JasonFengJ9 JasonFengJ9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JasonFengJ9 JasonFengJ9 merged commit 5d12119 into adoptium:master Oct 31, 2023
1 check passed
llxia added a commit to llxia/aqa-tests that referenced this pull request Nov 22, 2023
@llxia
Allow users to set docker info (adoptium#4748)
0cffeb2 
Signed-off-by: Lan Xia <[email protected]>
llxia added a commit to llxia/aqa-tests that referenced this pull request Nov 22, 2023
@llxia
Allow users to set docker info (adoptium#4748)
202dd9b 
Signed-off-by: Lan Xia <[email protected]>
pshipton pushed a commit that referenced this pull request Nov 22, 2023
@llxia @pshipton
Allow users to set docker info (#4748)
90ed3e1 
Signed-off-by: Lan Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LongyuZhang LongyuZhang LongyuZhang approved these changes

@JasonFengJ9 JasonFengJ9 JasonFengJ9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow users to set docker info in AQA_Test_Pipeline
3 participants
@llxia @JasonFengJ9 @LongyuZhang