-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude failing tests using vm.continuations flag #4738
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 30, 2023
babsingh
reviewed
Aug 30, 2023
java/lang/Thread/virtual/CarrierThreadWaits.java#id0 eclipse-openj9/openj9#18051 java/lang/Thread/virtual/GetStackTrace.java eclipse-openj9/openj9#18052 serviceability/jvmti/vthread/FollowReferences/VThreadStackRefTest.java#default eclipse-openj9/openj9#18053 serviceability/jvmti/vthread/ThreadStateTest/ThreadStateTest.java eclipse-openj9/openj9#18054 Signed-off-by: Jack Lu <[email protected]>
babsingh
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@llxia @LongyuZhang Requesting your review.
llxia
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
karianna
approved these changes
Sep 1, 2023
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Sep 5, 2023
Related: adoptium#4738. Add individual excludes for each VThreadStackRefTest variant. Related: eclipse-openj9/openj9#16728. Exclude Skynet.java#default until further investigation is performed. Signed-off-by: Babneet Singh <[email protected]>
Merged
llxia
pushed a commit
that referenced
this pull request
Sep 5, 2023
Related: #4738. Add individual excludes for each VThreadStackRefTest variant. Related: eclipse-openj9/openj9#16728. Exclude Skynet.java#default until further investigation is performed. Signed-off-by: Babneet Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java/lang/Thread/virtual/CarrierThreadWaits.java#id0 eclipse-openj9/openj9#18051 java/lang/Thread/virtual/GetStackTrace.java eclipse-openj9/openj9#18052 serviceability/jvmti/vthread/FollowReferences/VThreadStackRefTest.java#default eclipse-openj9/openj9#18053 serviceability/jvmti/vthread/ThreadStateTest/ThreadStateTest.java eclipse-openj9/openj9#18054