Adding Kafka under third party tests #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mesbah-Alam
reviewed
Jul 9, 2018
| ls . | ||
| pwd | ||
|
|
||
|
|
There was a problem hiding this comment.
Please remove extra spaces here.
Mesbah-Alam
reviewed
Jul 9, 2018
| gradle -q | ||
| ./gradlew jar | ||
|
|
||
|
|
There was a problem hiding this comment.
Please remove extra spaces
Mesbah-Alam
approved these changes
Jul 9, 2018
| echo "java -version is: \n" | ||
| java -version | ||
|
|
||
| # Replace the following with the initial command lines that trigger execution of your test |
There was a problem hiding this comment.
Please replace this template comment with something like "Initial command to trigger Kafka tests".
There was a problem hiding this comment.
done..Replaced with "Initial command to trigger the execution of kafka test"
| unzip \ | ||
| vim \ | ||
| wget | ||
|
|
There was a problem hiding this comment.
Please remove extra space
| && rm -rf gradle-4.5-bin.zip \ | ||
| && ln -s /usr/share/gradle/gradle-4.5/bin/gradle /usr/bin/gradle \ | ||
| && cd / | ||
|
|
There was a problem hiding this comment.
Please remove extra space
terryzuoty
reviewed
Jul 11, 2018
| <playlist xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../TestConfig/playlist.xsd"> | ||
| <test> | ||
| <testCaseName>kafka_test</testCaseName> | ||
| <command>docker run --rm -v $(JDK_HOME):/java adoptopenjdk-kafka-test:latest "jvm pos neg"; \ |
There was a problem hiding this comment.
Are these "jvm pos neg" in the command section also used for Kafka tests?
There was a problem hiding this comment.
Not needed, have removed them now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created to add Kafka under third party applications test. Below is the personal build which ran with the changes under my fork.
https://ci.adoptopenjdk.net/view/work%20in%20progress/job/test_personal/629/consoleFull
Build was successful but tests failed, for which we will raise defects..
Please review the changes and approve