Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Un-exclude MathLoadTest on JDK20 #4503

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Un-exclude MathLoadTest on JDK20 #4503

merged 1 commit into from
Apr 12, 2023

Conversation

Mesbah-Alam
Copy link
Contributor

@Mesbah-Alam
Copy link
Contributor Author

Mesbah-Alam commented Apr 11, 2023 •
edited
Loading

Test : Grinder_JCK/1281 (green)

@Mesbah-Alam Mesbah-Alam mentioned this pull request Apr 11, 2023
Merged
@Mesbah-Alam Mesbah-Alam marked this pull request as ready for review April 12, 2023 15:32
llxia
llxia approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophia-guo sophia-guo merged commit 81eefe0 into adoptium:master Apr 12, 2023
@smlambert
Copy link
Contributor

Did someone test this against Temurin? Presume it works, but I did not see public grinders.

@sophia-guo
Copy link
Contributor

sophia-guo commented Apr 12, 2023 •
edited
Loading

Tests are excluded by eclipse-openj9/openj9#16254, which is a dup of adoptium/aqa-systemtest#482. The fix adoptium/aqa-systemtest#483 has been tested by jdk20 March release with target MiniMix_** ( though not this specific test). I will run a grinder to double check.

@sophia-guo
Copy link
Contributor

Run one test target MathLoadTest_all_5m on linux-x64 https://ci.adoptium.net/view/Test_grinder/job/Grinder/7126/console, passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia approved these changes

@sophia-guo sophia-guo sophia-guo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mesbah-Alam @smlambert @sophia-guo @llxia