Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexclude runtime/NMT/HugeArenaTracking.java windows-x86 on JDK8 #4293

Merged

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Jan 31, 2023

Test runtime/NMT/HugeArenaTracking.java was fixed on windows-x86 + JDK8 by JDK-8241086 backport:
openjdk/jdk8u-dev#182

Fixes #2650

(kept excluded on solaris-x64 - that is separate issue)

@smlambert
Copy link
Contributor

@zzambers
Copy link
Contributor Author

zzambers commented Feb 2, 2023

@smlambert I think TARGET supposed to be hotspot_custom rather than jdk_custom

@smlambert
Copy link
Contributor

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @zzambers !

@zzambers
Copy link
Contributor Author

zzambers commented Feb 2, 2023

@smlambert, oh, and one more thing, we should test this (and the other one) on 32-bit windows. Sorry, I have only later noticed, that it seems to be running on 64-bit windows.

@smlambert
Copy link
Contributor

@sophia-guo sophia-guo self-requested a review February 2, 2023 15:15
@sophia-guo sophia-guo merged commit 887a846 into adoptium:master Feb 2, 2023
@smlambert
Copy link
Contributor

smlambert commented Feb 2, 2023

The solaris issue is listed in the problemlist file: adoptium/infrastructure#2565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extended.openjdk runtime/NMT/HugeArenaTracking.java jdk8 win32 fails with insufficient memory
3 participants