Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set parent result based on child result #4255

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Set parent result based on child result #4255

merged 1 commit into from
Jan 26, 2023

Conversation

renfeiw
Copy link
Contributor

@renfeiw renfeiw commented Jan 18, 2023

  • fix the false positive issue caused by TAP parser

Fixes #4237

Signed-off-by: renfeiw [email protected]

@renfeiw renfeiw requested a review from llxia January 18, 2023 19:08
@renfeiw
Copy link
Contributor Author

renfeiw commented Jan 18, 2023

Grinder_TKG/1762

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@renfeiw renfeiw marked this pull request as draft January 18, 2023 22:16
- fix the false positive issue caused by TAP parser

Fixes adoptium#4237

Signed-off-by: renfeiw <[email protected]>
@renfeiw
Copy link
Contributor Author

renfeiw commented Jan 18, 2023

Grinder_TKG/1764, Grinder_TKG/1765

@renfeiw renfeiw marked this pull request as ready for review January 26, 2023 21:32
@llxia llxia merged commit 6ac67c0 into adoptium:master Jan 26, 2023
@llxia
Copy link
Contributor

llxia commented Jan 27, 2023

@renfeiw could you please back port the change into the aqa release branch https://github.com/adoptium/aqa-tests/tree/v0.9.6-release? We will have RC2 build soon. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

false positive test build
3 participants