Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable FFI test suites for JDK17, 19 and beyond #4226

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

ChengJin01
Copy link

The change is to enable the majority of FFI specific test suites except the Hotspot related tests plus
a couple of failing tests being investigated given everything intended for FFI has been implemented
in OpenJ9.

Signed-off-by: ChengJin01 [email protected]

The change is to enable the majority of FFI specific
test suites except the Hotspot related tests plus
a couple of failing tests being investigated given
everything intended for FFI has been implemented
in OpenJ9.

Signed-off-by: ChengJin01 <[email protected]>
@ChengJin01 ChengJin01 force-pushed the enable_ffi_tests_jdk17_19_next branch from 7176a1c to b176901 Compare January 4, 2023 17:03
@ChengJin01
Copy link
Author

ChengJin01 commented Jan 4, 2023

I'd like to enable most of FFI test suites passed in the Grinders in JDK17 & 19 with all Hotspot specific tests excluded:
https://openj9-jenkins.osuosl.org/job/Grinder/1787/console (JDK17)
https://openj9-jenkins.osuosl.org/job/Grinder/1797/console (JDK19)

So far, there are only two disabled test suites to be addressed:
java/foreign/TestHandshake.java eclipse-openj9/openj9#13211 (being investigated by JIT)
java/foreign/StdLibTest.java eclipse-openj9/openj9#16386 aix-ppc64 (failure to find strcat on AIX in JDK19)

Note:

  1. The issue with NoSuchMethodError from MethodHandle.invokeBasic in TestDowncallScope.java is not excluded as it is an intermittent failure which is already identified at OpenJDK java/foreign/TestDowncallScope.java NoSuchMethodError MethodHandle.invokeBasic eclipse-openj9/openj9#16161 (being investigated by JIT)
  2. The FFI specific code in JDK20+ is the same as JDK19 for the moment given we have not yet merged the latest changes at Merge master HEAD into openj9-staging ibmruntimes/openj9-openjdk-jdk#531 (which is intended for JEP434 at JEP 434: Foreign Function & Memory API (Second Preview) eclipse-openj9/openj9#16329)

@ChengJin01
Copy link
Author

Reviewer: @llxia, @ShelleyLambert
FYI: @tajila, @pshipton

Copy link
Contributor

@Mesbah-Alam Mesbah-Alam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice to see problem lists get reduced :-)

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants