Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AttachTest in JDK19+ #4068

Merged

Conversation

ChengJin01
Copy link

The change is to enable AttachTest given
the upcall thunk was implemented on all
supported platforms.

Signed-off-by: Cheng Jin [email protected]

The change is to enable AttachTest given
the upcall thunk was implemented on all
supported platforms.

Signed-off-by: Cheng Jin <[email protected]>
@ChengJin01
Copy link
Author

The PR is to enable the failing test previously detected at eclipse-openj9/openj9#15466.

Reviewer: @llxia
FYI: @ShelleyLambert, @tajila, @pshipton.

@ChengJin01
Copy link
Author

ChengJin01 commented Oct 20, 2022

Launched a Grinder at https://hyc-runtimes-jenkins.swg-devops.com/view/Test_grinder/job/Grinder/28854/ on all required platforms (Linux & macOS) as required by the test.

@llxia
Copy link
Contributor

llxia commented Oct 21, 2022

@ChengJin01 just fyi, Grinder does not support using https://openj9-artifactory.osuosl.org/artifactory/ci-openj9/Build_JDK${JDK_VERSION}_${PLATFORM}_Nightly/ with JDK_VERSION=next. It does not know which JDK to download.

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChengJin01
Copy link
Author

There was no issue detected at https://hyc-runtimes-jenkins.swg-devops.com/view/Test_grinder/job/Grinder/28854/ based on the outputs of the passed Grinders in JDK19.

@sophia-guo sophia-guo merged commit 810d5fa into adoptium:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants