Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to JAVA_ARGS #4052

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Revert to JAVA_ARGS #4052

merged 1 commit into from
Oct 19, 2022

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Oct 18, 2022

JVM_OPTIONS got set before the mode was set. This issue affects all system tests with Mode. No Modes were passed in the system tests for the past month. For details, please see eclipse-openj9/openj9#15250 (comment)

Revert back to set JVM_OPTIONS in JAVA_ARGS (see the original PR #3972)

Related: eclipse-openj9/openj9#15250

Signed-off-by: Lan Xia [email protected]

@llxia
Copy link
Contributor Author

llxia commented Oct 18, 2022

openj9: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/5793

20:03:31  variation: Mode112
20:03:31  JVM_OPTIONS:  -Xgcpolicy:gencon -Xjit:count=0 -Xnocompressedrefs 
... -java-args=' -Xgcpolicy:gencon -Xjit:count=0 -Xnocompressedrefs  -Xdump:system:events=user'

hotspot: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/5794

20:03:25  variation: Mode150
20:03:25  JVM_OPTIONS:  -XX:+UseCompressedOops 
... -java-args=' -XX:+UseCompressedOops '

@llxia llxia marked this pull request as ready for review October 19, 2022 00:10
Copy link
Contributor

@renfeiw renfeiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smlambert smlambert merged commit fa73e7b into adoptium:master Oct 19, 2022
llxia added a commit to llxia/aqa-tests that referenced this pull request Oct 19, 2022
smlambert pushed a commit that referenced this pull request Oct 19, 2022
Related: eclipse-openj9/openj9#15250

Signed-off-by: Lan Xia <[email protected]>

Signed-off-by: Lan Xia <[email protected]>

Signed-off-by: Lan Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants