-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude jdk_tools testcase VersionCheck.java #3758
Conversation
Exclude jdk_tools testcase tools/launcher/VersionCheck.java only vendor is alibaba Fixes: #3751 Signed-off-by: sendaoYan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, but I will note that we will be adding auto-reenablement of tests in the future, where we check the status of the issue, and if its closed, as #3751 will be once this is merged, we will automatically try to run the test again to reinclude it. For exclusions that will be "permanent", we may want to use a single issue that tracks all of the individual issues that we are covering as part of this effort to remove testcases that are not applicable to a Dragonwell implementation. (Much like we did for OpenJ9, and then we can tell our automation to ignore re-enabling if issueX is referenced in the problemlist.
@smlambert |
I mean that we can create an issue similar to this one, #1297 but for Dragonwell, then it can be used as the reference issue in the problem list (and we would link all of the specific issues to it, so we can see the details and good explanation of each testcase failure that you've investigated). I have created this issue, #3763 which we can use. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but suggest a change to reference the umbrella issue. It is still good and important to have the individual issues that you are raising to explain the details, and link those individual issues to the umbrella issue #3763
Exclude jdk_jdi testcase com/sun/jdi/StepTest.java only vendor is alibaba Fixes: #3756 Signed-off-by: sendaoYan <[email protected]>
Exclude jdk_tools testcase tools/launcher/VersionCheck.java only vendor is alibaba Fixes: #3751 Signed-off-by: sendaoYan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Exclude jdk_tools testcase tools/launcher/VersionCheck.java only vendor is alibaba
Fixes: #3751
Signed-off-by: sendaoYan [email protected]