Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude jdk_tools testcase VersionCheck.java #3758

Merged
merged 4 commits into from
Jun 14, 2022
Merged

Exclude jdk_tools testcase VersionCheck.java #3758

merged 4 commits into from
Jun 14, 2022

Conversation

sendaoYan
Copy link
Contributor

Exclude jdk_tools testcase tools/launcher/VersionCheck.java only vendor is alibaba

Fixes: #3751

Signed-off-by: sendaoYan [email protected]

Exclude jdk_tools testcase tools/launcher/VersionCheck.java only vendor is alibaba

Fixes: #3751
Signed-off-by: sendaoYan <[email protected]>
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I will note that we will be adding auto-reenablement of tests in the future, where we check the status of the issue, and if its closed, as #3751 will be once this is merged, we will automatically try to run the test again to reinclude it. For exclusions that will be "permanent", we may want to use a single issue that tracks all of the individual issues that we are covering as part of this effort to remove testcases that are not applicable to a Dragonwell implementation. (Much like we did for OpenJ9, and then we can tell our automation to ignore re-enabling if issueX is referenced in the problemlist.

@sendaoYan
Copy link
Contributor Author

@smlambert
Do you mean all the testcases which not applicable to Dragonwell implementation, should track in a single issue?
Bacause #3759 has been merged, we can track all the others in #3751.

@smlambert
Copy link
Contributor

I mean that we can create an issue similar to this one, #1297 but for Dragonwell, then it can be used as the reference issue in the problem list (and we would link all of the specific issues to it, so we can see the details and good explanation of each testcase failure that you've investigated).

I have created this issue, #3763 which we can use.

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but suggest a change to reference the umbrella issue. It is still good and important to have the individual issues that you are raising to explain the details, and link those individual issues to the umbrella issue #3763

openjdk/excludes/vendors/alibaba/ProblemList_openjdk8.txt Outdated Show resolved Hide resolved
Exclude jdk_jdi testcase com/sun/jdi/StepTest.java only vendor is alibaba

Fixes: #3756

Signed-off-by: sendaoYan <[email protected]>
Exclude jdk_tools testcase tools/launcher/VersionCheck.java only vendor is alibaba

Fixes: #3751
Signed-off-by: sendaoYan <[email protected]>
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit 13dcb35 into adoptium:master Jun 14, 2022
@sendaoYan sendaoYan deleted the issue3751 branch June 15, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VersionCheck.java run fail by dragonwell8
3 participants