Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable FileEncodingTest FinalizationOption & InvalidFinalizationOption #3222

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Enable FileEncodingTest FinalizationOption & InvalidFinalizationOption #3222

merged 1 commit into from
Jan 19, 2022

Conversation

JasonFengJ9
Copy link
Contributor

@JasonFengJ9 JasonFengJ9 commented Jan 17, 2022

Re-enable following tests:

java/lang/System/FileEncodingTest.java
java/lang/Object/FinalizationOption.java
java/lang/Object/InvalidFinalizationOption.java

Depends on eclipse-openj9/openj9#14285 eclipse-openj9/openj9#14307

Related eclipse-openj9/openj9#14233 eclipse-openj9/openj9#14093
eclipse-openj9/openj9#14131

Signed-off-by: Jason Feng [email protected]

@JasonFengJ9 JasonFengJ9 marked this pull request as draft January 17, 2022 14:56
Re-enable following tests:
java/lang/System/FileEncodingTest.java
java/lang/Object/FinalizationOption.java
java/lang/Object/InvalidFinalizationOption.java

Signed-off-by: Jason Feng <[email protected]>
@JasonFengJ9 JasonFengJ9 changed the title WIP: Re-include java/lang/System/FileEncodingTest.java Enable FileEncodingTest FinalizationOption & InvalidFinalizationOption Jan 18, 2022
@JasonFengJ9 JasonFengJ9 marked this pull request as ready for review January 18, 2022 22:22
@JasonFengJ9
Copy link
Contributor Author

@llxia @Mesbah-Alam could you please review?

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Mesbah-Alam Mesbah-Alam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mesbah-Alam Mesbah-Alam merged commit 67acc4b into adoptium:master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants