Archive openjdk regression tests output including diagnostic files #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change workDir from $(TEST_RESROOT) to TKG $(REPORTDIR) so it will be archived by default - Do not need to archive *.jtr separately as *.jtr are under $(REPORTDIR) and they will be archived by default Signed-off-by: lanxia <[email protected]>
|
https://ci.eclipse.org/openj9/view/Test_grinder/job/Test-Grinder_Sandbox/28/ Output: dmp can be found in the archive: https://140-211-168-230-openstack.osuosl.org/artifactory/ci-eclipse-openj9/Test/Test-Grinder_Sandbox/28/ |
https://ci.adoptopenjdk.net/view/work%20in%20progress/job/Grinder_Sandbox/243/ |
|
Would like to deliver it after the release. Mark this PR WIP for now. |
llxia
changed the title
|
workDir is also the location for all executed tests, i.e. .class files. Probably filter those to reduce the archive size? |
|
I checked the tar size and .class files does not seem to affect much, so I will keep them for now. |
|
At one point very early on, we archived html files, but @akolarkunnu advised that the jtr files contained more information and were more useful, so we did not bother with the html files. I am happy to have this particular PR merged now (ahead of the release) if you like. We will still have 3 days to monitor runs before Tuesday, so the intent was locking the repo down later tonight. |
smlambert
approved these changes
Apr 12, 2019
|
Sorry Shelley, missed your msg last Friday. I am ok to merge it before release. Removing WIP. |
llxia
changed the title
|
Its not a problem to wait either (now that we are so close to the release, I will say we wait), also, since PR is still pending @sophia-guo 's review. |
sophia-guo
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
archived by default
*.jtrseparately in Jenkins file as*.jtrare under$(REPORTDIR) (i.e., test_output_*) now and they will be archived by default
Fixes: eclipse-openj9/openj9#5454
Signed-off-by: lanxia [email protected]