Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove check_version() in common_functions.sh for external tests #4949

Closed
llxia opened this issue Jan 9, 2024 · 4 comments · Fixed by #4954
Closed

Remove check_version() in common_functions.sh for external tests #4949

llxia opened this issue Jan 9, 2024 · 4 comments · Fixed by #4954
Assignees
@llxia
Labels
enhancement

Comments

@llxia
Copy link
Contributor

llxia commented Jan 9, 2024 

00:01:15.569       [exec] build_image.sh criu-ubi-portable-checkpoint 21 openj9 ubi jdk full linux_x86-64 ubi8-with-criu/linux_ppc-64_le-ubi8-criu 0 
00:01:15.569       [exec] ERROR: Invalid Version: 21
00:01:15.569       [exec] Usage: /home/jenkins/workspace/Test_openjdk21_j9_dev.external_ppc64le_linux_imageUpload/aqa-tests/TKG/../../jvmtest/external/external.sh [8 11 17]

job link

I will add 21 at https://github.com/adoptium/aqa-tests/blob/master/external/common_functions.sh#L17 for now.
However, the root question is why we have Supported versions list at all.
@llxia llxia changed the title external tests cannot run against JDK21 external tests cannot run against JDK21+ Jan 9, 2024
llxia added a commit to llxia/aqa-tests that referenced this issue Jan 9, 2024
@llxia
Add 21 and 22 as supported versions in external tests
93ba160 
related: adoptium#4949
Signed-off-by: Lan Xia <[email protected]>
@llxia llxia mentioned this issue Jan 9, 2024
Merged
@llxia
Copy link
Contributor Author

llxia commented Jan 9, 2024 •
edited
Loading

@smlambert @sophia-guo do you have any idea why we have the Supported versions list in external tests? If we do not have a specific reason for it, I would suggest removing check_version() from common_functions.sh

@llxia llxia assigned smlambert and llxia and unassigned smlambert Jan 9, 2024
@smlambert
Copy link
Contributor

I do not recall that there is a good reason to limit, in fact, I vaguely recall it was an area that we were planning to simplify. For external tests that can not run in later versions of Java, we can control that in the playlist for those targets.

smlambert pushed a commit that referenced this issue Jan 9, 2024
@llxia
Add 21 and 22 as supported versions in external tests (#4950)
37b48e3 
related: #4949

Signed-off-by: Lan Xia <[email protected]>
@llxia
Copy link
Contributor Author

llxia commented Jan 9, 2024

Thanks @smlambert . I will update the issue title to reflect the required action.

@llxia llxia changed the title external tests cannot run against JDK21+ Remove check_version() in common_functions.sh for external tests Jan 9, 2024
@llxia
Copy link
Contributor Author

llxia commented Jan 9, 2024

@annaibm can you work on this when you have time? Thanks

annaibm added a commit to annaibm/aqa-tests that referenced this issue Jan 10, 2024
@annaibm
Remove check_version in common_functions.sh
a635f5f 
resolves : adoptium#4949

Signed-off-by: Anna Babu Palathingal <[email protected]>
@annaibm annaibm mentioned this issue Jan 10, 2024
Merged
annaibm added a commit to annaibm/aqa-tests that referenced this issue Jan 10, 2024
@annaibm
Remove check_version in common_functions.sh
e4a9277 
- remove check_version function
- remove set_version function
resolves : adoptium#4949

Signed-off-by: Anna Babu Palathingal <[email protected]>
annaibm added a commit to annaibm/aqa-tests that referenced this issue Jan 11, 2024
@annaibm
Remove check_version in common_functions.sh
52c9eb6 
- remove check_version function
- remove set_version function
resolves : adoptium#4949

Signed-off-by: Anna Babu Palathingal <[email protected]>
sophia-guo pushed a commit to sophia-guo/openjdk-tests that referenced this issue Jan 11, 2024
@llxia @sophia-guo
Add 21 and 22 as supported versions in external tests (adoptium#4950)
eb6236b 
related: adoptium#4949

Signed-off-by: Lan Xia <[email protected]>
smlambert added a commit that referenced this issue Jan 11, 2024
@sophia-guo @sxa
@luhenry @pshipton @smlambert @llxia
(V1.0.0-release ) cherry pick (#4959)
626eb0d 
* Use all cores for jtreg instead of halving (#4933)

Signed-off-by: Stewart X Addison <[email protected]>

* Enable headless mode on RISC-V (#4935)

* Exclude java/lang/StringBuilder/HugeCapacity.java on OpenJ9 zlinux (#4940)

It's already excluded on jdk17+ for other reasons.

Issue eclipse-openj9/openj9#17323

Signed-off-by: Peter Shipton <[email protected]>

* Move custom targets to special level (#4941)

Signed-off-by: Shelley Lambert <[email protected]>

* Add 21 and 22 as supported versions in external tests (#4950)

related: #4949

Signed-off-by: Lan Xia <[email protected]>

* cherry-pick

e37ba10 c5e7de8 0d7c837 76695ca 37b48e3 a45c03c

Signed-off-by: Sophia Guo <[email protected]>

---------

Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Peter Shipton <[email protected]>
Signed-off-by: Shelley Lambert <[email protected]>
Signed-off-by: Lan Xia <[email protected]>
Signed-off-by: Sophia Guo <[email protected]>
Co-authored-by: Stewart X Addison <[email protected]>
Co-authored-by: Ludovic Henry <[email protected]>
Co-authored-by: Peter Shipton <[email protected]>
Co-authored-by: Shelley Lambert <[email protected]>
Co-authored-by: Lan Xia <[email protected]>
annaibm added a commit to annaibm/aqa-tests that referenced this issue Jan 17, 2024
@annaibm
Remove check_version in common_functions.sh
5a29c49 
- remove check_version function
- remove set_version function
resolves : adoptium#4949

Signed-off-by: Anna Babu Palathingal <[email protected]>
annaibm added a commit to annaibm/aqa-tests that referenced this issue Jan 17, 2024
@annaibm
Remove check_version in common_functions.sh
fb46146 
- remove check_version function
- remove set_version function
resolves : adoptium#4949

Signed-off-by: Anna Babu Palathingal <[email protected]>
annaibm added a commit to annaibm/aqa-tests that referenced this issue Jan 30, 2024
@annaibm
Remove check_version in common_functions.sh
cbf9aaf 
- remove check_version function
- remove set_version function
resolves : adoptium#4949

Signed-off-by: Anna Babu Palathingal <[email protected]>
annaibm added a commit to annaibm/aqa-tests that referenced this issue Jan 30, 2024
@annaibm
Remove check_version in common_functions.sh
bd9bd9e 
- remove check_version function
- remove set_version function
resolves : adoptium#4949

Signed-off-by: Anna Babu Palathingal <[email protected]>
annaibm added a commit to annaibm/aqa-tests that referenced this issue Jan 30, 2024
@annaibm
Remove check_version in common_functions.sh
3e1618e 
- remove check_version function
- remove set_version function
resolves : adoptium#4949

Signed-off-by: Anna Babu Palathingal <[email protected]>
annaibm added a commit to annaibm/aqa-tests that referenced this issue Jan 30, 2024
@annaibm
Remove check_version in common_functions.sh
4c09020 
- remove check_version function
- remove set_version function
resolves : adoptium#4949

Signed-off-by: Anna Babu Palathingal <[email protected]>
annaibm added a commit to annaibm/aqa-tests that referenced this issue Jan 31, 2024
@annaibm
Remove check_version in common_functions.sh
ac9a0ca 
- remove check_version function
- remove set_version function
- remove supported_versions
resolves : adoptium#4949

Signed-off-by: Anna Babu Palathingal <[email protected]>
annaibm added a commit to annaibm/aqa-tests that referenced this issue Jan 31, 2024
@annaibm
Remove check_version in common_functions.sh
3593e29 
- remove check_version function
- remove set_version function
- remove supported_versions
resolves : adoptium#4949

Signed-off-by: Anna Babu Palathingal <[email protected]>
LongyuZhang pushed a commit that referenced this issue Feb 6, 2024
@annaibm
Remove check_version in common_functions.sh (#4954)
e32dc86 
- remove check_version function
- remove set_version function
- remove supported_versions
resolves : #4949

Signed-off-by: Anna Babu Palathingal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@llxia llxia

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove check_version in common_functions.sh annaibm/aqa-tests
2 participants
@smlambert @llxia