Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jdk8, jdk11, jdk16 win32 Hotspot extended.openjdk Unrecognized VM options #2382

Closed
andrew-m-leonard opened this issue Mar 15, 2021 · 11 comments · Fixed by #5416
Closed

jdk8, jdk11, jdk16 win32 Hotspot extended.openjdk Unrecognized VM options #2382

andrew-m-leonard opened this issue Mar 15, 2021 · 11 comments · Fixed by #5416
Labels
JBS issue need to report to JBS or reopen the issue in JBS release triage

Comments

@andrew-m-leonard
Copy link
Contributor

https://ci.adoptopenjdk.net/job/Test_openjdk16_hs_extended.openjdk_x86-32_windows/9/consoleFull

12:03:11  Unrecognized VM option 'ReduceBulkZeroing'
12:03:11  Unrecognized VM option 'StressGCM'
12:03:37  Unrecognized VM option 'MaxVectorSize=8'
12:06:36  Unrecognized VM option 'SplitIfBlocks'
12:09:06  Unrecognized VM option 'SuperWordLoopUnrollAnalysis'
12:23:32  Unrecognized VM option 'LoopUnrollLimit=250'
12:24:24  Unrecognized VM option 'PartialPeelLoop'
12:24:24  Unrecognized VM option 'LoopMaxUnroll=0'
12:24:51  Unrecognized VM option 'UseLoopPredicate'
12:29:07  Unrecognized VM option 'DoEscapeAnalysis'
12:29:54  Unrecognized VM option 'UseCountedLoopSafepoints'
@sophia-guo
Copy link
Contributor

https://bugs.openjdk.java.net/browse/JDK-8252473

@sophia-guo sophia-guo added the JBS issue need to report to JBS or reopen the issue in JBS label Mar 15, 2021
@smlambert
Copy link
Contributor

If this is the case, we should disable the affected tests referencing the upstream issue (and closing this one).

@smlambert
Copy link
Contributor

As a general rule, I do NOT want to hold open duplicate issues in this repo for things that are raised in other repos (including openjdk-infrastructure and JBS).

I recognize we are currently doing that right now, and we are holding a handful of issues open in openjdk-tests that are actually reported elsewhere. Where possible, we should fix this in Problemlist and playlists to reference the actual issue and remove the placeholder.

In this way we can reduce the quickly growing backlog in this repo. Also, in the case where @andrew-m-leonard is raising all of these unique issues for each failure causing a big bloating surge of issues, we should likely reference the earlier duplicate reports that are sitting in more general issues (example: #2137).

@smlambert
Copy link
Contributor

Failing targets on this platform:
jvm_compiler, jdk_io, jdk_management, jdk_tools
that contain 64 failing testcases out of 4806 extended.openjdk testcases (as reported here).

Before excluding all 4 targets completely, we should see if there are ways to fix some of the issues that are not related to Unrecognized VM options. Then check if some only have a few testcases failing (if so, exclude via problemlist, to keep as many other test cases running).

For jdk_tools:

10:27:15  STDERR:
10:27:15  java.lang.AssertionError: HelpFlagsTest failed:
10:27:15  Tool jaccessinspector-32.exe not covered by this test. Add specification to jdkTools array!
10:27:15  Tool jaccesswalker-32.exe not covered by this test. Add specification to jdkTools array!
10:27:15  
10:27:15  	at HelpFlagsTest.main(HelpFlagsTest.java:374)
10:27:15  	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
10:27:15  	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
10:27:15  	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
10:27:15  	at java.base/java.lang.reflect.Method.invoke(Method.java:567)
10:27:15  	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:298)
10:27:15  	at java.base/java.lang.Thread.run(Thread.java:831)
10:27:15  
10:27:15  JavaTest Message: Test threw exception: java.lang.AssertionError
10:27:15  JavaTest Message: shutting down test
10:27:15

@lumpfish lumpfish mentioned this issue Mar 16, 2021
Closed
1 task
@lumpfish
Copy link
Contributor

These failures appear to be Win32 specific and across all releases.
Presumably the options are only recognised by a GC implementation which is not built on win32?
I'll create a PR to exclude the tests pending a more thorough investigation.

@lumpfish
Copy link
Contributor

From the different releases:

jdk8 win32 hotspot extended.openjdk:

Running test hotspot_jre_2 ...
TEST: compiler/rangechecks/RangeCheckEliminationScaleNotOne.java
Unrecognized VM option 'UseLoopPredicate'
TEST: compiler/c2/cr6340864/TestByteVect.java
Unrecognized VM option 'MaxVectorSize=8'
TEST: compiler/c2/cr6340864/TestDoubleVect.java
Unrecognized VM option 'MaxVectorSize=8'
TEST: compiler/c2/cr6340864/TestFloatVect.java
Unrecognized VM option 'MaxVectorSize=8'
TEST: compiler/c2/cr6340864/TestIntVect.java
Unrecognized VM option 'MaxVectorSize=8'
TEST: compiler/c2/cr6340864/TestLongVect.java
Unrecognized VM option 'MaxVectorSize=8'
TEST: compiler/c2/cr6340864/TestShortVect.java
Unrecognized VM option 'MaxVectorSize=8'
TEST: compiler/codegen/TestCharVect2.java
Unrecognized VM option 'MaxVectorSize=8'
TEST: compiler/EscapeAnalysis/TestGetClass.java
Unrecognized VM option 'DisableIntrinsic=_getClass'

jdk11 win32 hotspot extended.openjdk:

Running test jvm_compiler_2 ...
TEST: compiler/arraycopy/TestCloneAccess.java
Unrecognized VM option 'ReduceBulkZeroing'
TEST: compiler/arraycopy/TestCloneAccessStressGCM.java
Unrecognized VM option 'StressGCM'
TEST: compiler/c2/cr6340864/TestByteVect.java
Unrecognized VM option 'MaxVectorSize=8'
TEST: compiler/c2/cr6340864/TestDoubleVect.java
Unrecognized VM option 'MaxVectorSize=8'
TEST: compiler/c2/cr6340864/TestFloatVect.java
Unrecognized VM option 'MaxVectorSize=8'
TEST: compiler/c2/cr6340864/TestIntVect.java
Unrecognized VM option 'MaxVectorSize=8'
TEST: compiler/c2/cr6340864/TestLongVect.java
Unrecognized VM option 'MaxVectorSize=8'
TEST: compiler/c2/cr6340864/TestShortVect.java
Unrecognized VM option 'MaxVectorSize=8'
TEST: compiler/c2/TestReplaceEquivPhis.java
Unrecognized VM option 'SplitIfBlocks'
TEST: compiler/codegen/TestCharVect2.java
Unrecognized VM option 'MaxVectorSize=8'
TEST: compiler/loopopts/TestUnswitchCloneSkeletonPredicates.java
Unrecognized VM option 'PartialPeelLoop'
TEST: compiler/loopstripmining/AntiDependentLoadInOuterStripMinedLoop.java
Unrecognized VM option 'LoopMaxUnroll=0'
TEST: compiler/loopstripmining/LoadDependsOnIfIdenticalToLoopExit.java
Unrecognized VM option 'LoopMaxUnroll=0'
TEST: compiler/loopstripmining/TestConservativeAntiDep.java
Unrecognized VM option 'LoopMaxUnroll=0'
TEST: compiler/loopstripmining/TestEliminatedLoadPinnedOnBackedge.java
Unrecognized VM option 'LoopUnrollLimit=0'
TEST: compiler/rangechecks/RangeCheckEliminationScaleNotOne.java
Unrecognized VM option 'UseLoopPredicate'
TEST: compiler/vectorization/TestVectorsNotSavedAtSafepoint.java
Unrecognized VM option 'UseCountedLoopSafepoints'

jdk16 win32 hotspot extended.openjdk:

Running test jvm_compiler_2 ...
TEST: compiler/arraycopy/TestCloneAccess.java
Unrecognized VM option 'ReduceBulkZeroing'
TEST: compiler/arraycopy/TestCloneAccessStressGCM.java
Unrecognized VM option 'StressGCM'
TEST: compiler/c2/cr6340864/TestByteVect.java
Unrecognized VM option 'MaxVectorSize=8'
TEST: compiler/c2/cr6340864/TestDoubleVect.java
Unrecognized VM option 'MaxVectorSize=8'
TEST: compiler/c2/cr6340864/TestFloatVect.java
Unrecognized VM option 'MaxVectorSize=8'
TEST: compiler/c2/cr6340864/TestIntVect.java
Unrecognized VM option 'MaxVectorSize=8'
TEST: compiler/c2/cr6340864/TestIntVectRotate.java
Unrecognized VM option 'MaxVectorSize=8'
TEST: compiler/c2/cr6340864/TestLongVect.java
Unrecognized VM option 'MaxVectorSize=8'
TEST: compiler/c2/cr6340864/TestLongVectRotate.java
Unrecognized VM option 'MaxVectorSize=8'
TEST: compiler/c2/cr6340864/TestShortVect.java
Unrecognized VM option 'MaxVectorSize=8'
TEST: compiler/c2/TestReplaceEquivPhis.java
Unrecognized VM option 'SplitIfBlocks'
TEST: compiler/c2/TestShiftRightAndAccumulate.java
Unrecognized VM option 'SuperWordLoopUnrollAnalysis'
TEST: compiler/codegen/TestCharVect2.java
Unrecognized VM option 'MaxVectorSize=8'
TEST: compiler/loopopts/superword/Vec_MulAddS2I.java
Unrecognized VM option 'LoopUnrollLimit=250'
TEST: compiler/loopopts/TestUnswitchCloneSkeletonPredicates.java
Unrecognized VM option 'PartialPeelLoop'
TEST: compiler/loopstripmining/AntiDependentLoadInOuterStripMinedLoop.java
Unrecognized VM option 'LoopMaxUnroll=0'
TEST: compiler/loopstripmining/LoadDependsOnIfIdenticalToLoopExit.java
Unrecognized VM option 'LoopMaxUnroll=0'
TEST: compiler/loopstripmining/TestConservativeAntiDep.java
Unrecognized VM option 'LoopMaxUnroll=0'
TEST: compiler/loopstripmining/TestEliminatedLoadPinnedOnBackedge.java
Unrecognized VM option 'LoopUnrollLimit=0'
TEST: compiler/rangechecks/RangeCheckEliminationScaleNotOne.java
Unrecognized VM option 'UseLoopPredicate'
TEST: compiler/types/TestSubTypeCheckMacroNodeWrongMem.java
Unrecognized VM option 'DoEscapeAnalysis'
TEST: compiler/vectorization/TestVectorsNotSavedAtSafepoint.java
Unrecognized VM option 'UseCountedLoopSafepoints'

jdk17 may also have similar failures, but the test jobs are not running successfully at the moment.

@lumpfish lumpfish changed the title jdk-16 Hotspot extended.openjdk Unrecognized VM options jdk8, jdk11, jdk16 Hotspot extended.openjdk Unrecognized VM options Jun 15, 2021
@lumpfish lumpfish changed the title jdk8, jdk11, jdk16 Hotspot extended.openjdk Unrecognized VM options jdk8, jdk11, jdk16 win32 Hotspot extended.openjdk Unrecognized VM options Jun 15, 2021
@lumpfish lumpfish mentioned this issue Jun 17, 2021
Merged
This was referenced Aug 26, 2021
Closed
Closed
@andrew-m-leonard andrew-m-leonard mentioned this issue Sep 16, 2021
Closed
This was referenced Oct 14, 2021
Closed
Closed
@sophia-guo sophia-guo mentioned this issue Oct 21, 2021
Closed
@sophia-guo sophia-guo mentioned this issue Jan 18, 2022
Closed
This was referenced Jan 19, 2022
Closed
Closed
@Haroon-Khel Haroon-Khel mentioned this issue Feb 9, 2022
Closed
@sophia-guo
Copy link
Contributor

sophia-guo commented Mar 23, 2022 •
edited
Loading

jdk18 on x86-32_windows compiler/c2/TestDeadDataLoopCmoveIdentity.java.TestDeadDataLoopCmoveIdentity
compiler/c2/cr6340864/TestByteVect.java.TestByteVect
compiler/c2/cr6340864/TestDoubleVect.java.TestDoubleVect
compiler/c2/cr6340864/TestFloatVect.java.TestFloatVect
compiler/c2/cr6340864/TestIntVect.java.TestIntVect
compiler/c2/cr6340864/TestLongVect.java.TestLongVect
compiler/c2/cr6340864/TestShortVect.java.TestShortVect
compiler/loopstripmining/AntiDependentLoadInOuterStripMinedLoop.java.AntiDependentLoadInOuterStripMinedLoop
compiler/loopstripmining/LoadDependsOnIfIdenticalToLoopExit.java.LoadDependsOnIfIdenticalToLoopExit
compiler/loopstripmining/TestConservativeAntiDep.java.TestConservativeAntiDep
compiler/loopstripmining/TestEliminatedLoadPinnedOnBackedge.java.TestEliminatedLoadPinnedOnBackedge
compiler/rangechecks/RangeCheckEliminationScaleNotOne.java.RangeCheckEliminationScaleNotOne

Some of them are not listed in https://bugs.openjdk.java.net/browse/JDK-8252473, but are the same issue

@sophia-guo sophia-guo mentioned this issue Mar 23, 2022
Closed
@smlambert smlambert mentioned this issue May 4, 2022
Closed
@sophia-guo
Copy link
Contributor

sophia-guo commented Jun 28, 2022 •
edited
Loading

jdk17 win32

compiler/c2/TestCMoveInfiniteGVN.java.TestCMoveInfiniteGVN
compiler/c2/TestDeadDataLoopCmoveIdentity.java.TestDeadDataLoopCmoveIdentity
compiler/c2/TestModDivTopInput.java.TestModDivTopInput
compiler/loopopts/FillArrayWithUnsafe.java.FillArrayWithUnsafe
compiler/loopopts/TestPredicateInputBelowLoopPredicate.java.TestPredicateInputBelowLoopPredicate
compiler/c2/irTests/TestSkeletonPredicates.java.TestSkeletonPredicates
compiler/c2/irTests/TestStripMiningDropsSafepoint.java.TestStripMiningDropsSafepoint
compiler/c2/irTests/TestSuperwordFailsUnrolling.java.TestSuperwordFailsUnrolling
compiler/print/PrintInlining.java.PrintInlining

This was referenced Jun 29, 2022
Closed
Closed
@sophia-guo sophia-guo mentioned this issue Jul 7, 2022
Closed
@sophia-guo
Copy link
Contributor

jdk8 win32: compiler/EscapeAnalysis/TestGetClass.java
https://ci.adoptopenjdk.net/job/Test_openjdk8_hs_extended.openjdk_x86-32_windows_testList_1/55/testReport/compiler_EscapeAnalysis_TestGetClass/java/TestGetClass/

@sophia-guo sophia-guo mentioned this issue Jul 23, 2022
Closed
@karianna karianna mentioned this issue Sep 22, 2022
Closed
sophia-guo added a commit to sophia-guo/openjdk-tests that referenced this issue Oct 19, 2022
@sophia-guo
exclude tests with Unrecognized VM option
fe2ab95 
adoptium#2382 windows-x86

Signed-off-by: Sophia Guo <[email protected]>
@sophia-guo sophia-guo mentioned this issue Oct 19, 2022
Closed
2 tasks
sophia-guo added a commit to sophia-guo/openjdk-tests that referenced this issue Oct 20, 2022
@sophia-guo
exclude tests with Unrecognized VM option
b5767c4 
adoptium#2382 windows-x86

Signed-off-by: Sophia Guo <[email protected]>
@sophia-guo sophia-guo mentioned this issue Oct 20, 2022
Merged
@zdtsw zdtsw mentioned this issue Oct 20, 2022
Closed
llxia pushed a commit that referenced this issue Oct 20, 2022
@sophia-guo
exclude tests with Unrecognized VM option (#4064)
15014ec 
#2382 windows-x86

Signed-off-by: Sophia Guo <[email protected]>
sophia-guo added a commit to sophia-guo/openjdk-tests that referenced this issue Oct 20, 2022
@sophia-guo
exclude tests with Unrecognized VM option (adoptium#4064)
3414d44 
adoptium#2382 windows-x86

Signed-off-by: Sophia Guo <[email protected]>
smlambert pushed a commit that referenced this issue Oct 20, 2022
@sophia-guo
exclude tests with Unrecognized VM option (#4064) (#4067)
52be9c3 
#2382 windows-x86

Signed-off-by: Sophia Guo <[email protected]>

Signed-off-by: Sophia Guo <[email protected]>
@sophia-guo sophia-guo mentioned this issue Jan 20, 2023
Closed
@smlambert
Copy link
Contributor

smlambert commented Apr 25, 2023 •
edited
Loading

Additionally compiler/loopopts/TestRemoveEmptyLoop.java (see #4517 (comment)) and compiler/c2/irTests/TestFewIterationsCountedLoop.java (see #4515 (comment)).

@andrew-m-leonard
Copy link
Contributor Author

Failures seen for jdk-17.0.9+9 release: #4826 (comment)

TEST: compiler/loopopts/TestBackedgeLoadArrayFillMain.java
        Unrecognized VM option 'OptimizeFill'
TEST: compiler/loopopts/TestInfiniteLoopWithUnmergedBackedgesMain.java
        Unrecognized VM option 'LoopUnswitching'
TEST: compiler/loopopts/TestRemoveEmptyCountedLoop.java
        Unrecognized VM option 'StressGCM'
TEST: compiler/rangechecks/TestRangeCheckCmpUOverflowVsSub.java
        Unrecognized VM option 'StressCCP'
TEST: compiler/splitif/TestCrashAtIGVNSplitIfSubType.java
        Unrecognized VM option 'StressIGVN'

@andrew-m-leonard andrew-m-leonard mentioned this issue Oct 27, 2023
Closed
@smlambert smlambert mentioned this issue Jan 14, 2024
Closed
@sophia-guo sophia-guo mentioned this issue Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
JBS issue need to report to JBS or reopen the issue in JBS release triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

openjdk: Unexclude fixed hotspot_compiler tests on windows-x86 zzambers/aqa-tests
4 participants
@smlambert @sophia-guo @lumpfish @andrew-m-leonard