Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clone reference repo path is looking for '$HOME' #1789

Closed
AdamBrousseau opened this issue May 15, 2020 · 0 comments · Fixed by #1794
Closed

Clone reference repo path is looking for '$HOME' #1789

AdamBrousseau opened this issue May 15, 2020 · 0 comments · Fixed by #1794
Labels
bug
Milestone
May 2020

Comments

@AdamBrousseau
Copy link
Contributor

Describe the bug
https://github.com/AdoptOpenJDK/openjdk-tests/blame/fb7463af44f406b233def68085a7bfc5f4bb7e83/buildenv/jenkins/testJobTemplate#L204
#1484
I believe when this executes the job actually looks for $HOME/openjdk_cache instead of, for example /home/jenkins/openjdk_cache
I see this error on a machine which has the cache setup

Cloning the remote Git repository
Cloning repository https://github.com/AdoptOpenJDK/openjdk-tests.git
 > git init /home/jenkins/workspace/Test_openjdk8_j9_sanity.functional_ppc64le_linux_Nightly/openjdk-tests # timeout=10
ERROR: Reference path does not exist: $HOME/openjdk_cache

At OpenJ9 we pull this value based on what plaform we are running on as it changes from linux to osx to windows. Hardcoding it to /home/jenkins/openjdk_cache would be a slight improvement but it wouldn't help osx for example.

To Reproduce
Steps to reproduce the behavior (or Grinder rerun link):
Run a test job on a machine which has ~/openjdk_cache vs a machine which does not.

Expected behavior
Should find the cache.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.
@AdamBrousseau AdamBrousseau mentioned this issue May 15, 2020
Closed
@karianna karianna added this to the May 2020 milestone May 15, 2020
@karianna karianna added the bug label May 15, 2020
@karianna karianna removed this from the May 2020 milestone May 15, 2020
AdamBrousseau added a commit to AdamBrousseau/aqa-tests that referenced this issue May 23, 2020
@AdamBrousseau
Fix reference repo path for initial scm checkout
dd3b506 
It is currently set in the job config and propagated down
to the build during checkout scm. The problem is the
'$HOME' variable is not getting resolved so the clone
is looking for exactly that. Moving it out of the
job config (template) and into the pipeline will allow
it to be esolved properly. It is also not needed on the
job config because we use a lightweight checkout.

Fixes adoptium#1789

Signed-off-by: Adam Brousseau <[email protected]>
AdamBrousseau added a commit to AdamBrousseau/aqa-tests that referenced this issue May 23, 2020
@AdamBrousseau
Fix reference repo path for initial scm checkout
86bfeae 
It is currently set in the job config and propagated down
to the build during checkout scm. The problem is the
'$HOME' variable is not getting resolved so the clone
is looking for exactly that. Moving it out of the
job config (template) and into the pipeline will allow
it to be resolved properly. It is also not needed on the
job config because we use a lightweight checkout.

Fixes adoptium#1789

Signed-off-by: Adam Brousseau <[email protected]>
@AdamBrousseau AdamBrousseau mentioned this issue May 23, 2020
Merged
llxia pushed a commit that referenced this issue May 27, 2020
@AdamBrousseau
Fix reference repo path for initial scm checkout (#1794)
e5266c1 
It is currently set in the job config and propagated down
to the build during checkout scm. The problem is the
'$HOME' variable is not getting resolved so the clone
is looking for exactly that. Moving it out of the
job config (template) and into the pipeline will allow
it to be resolved properly. It is also not needed on the
job config because we use a lightweight checkout.

Fixes #1789

Signed-off-by: Adam Brousseau <[email protected]>
@karianna karianna added this to the May 2020 milestone May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
May 2020
Development

Successfully merging a pull request may close this issue.

Fix reference repo path for initial scm checkout AdamBrousseau/aqa-tests
2 participants
@karianna @AdamBrousseau