Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Mode650 on 32-bit platforms #137

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Jan 11, 2021

@sophia-guo
Copy link
Contributor

Should Mode150 be disabled as well? The Mode150 is skipped for now for hotspot with spec set as without suffix _mixed. With the plan to enabled Mode150 for hotspot later the same issue will be hit adoptium/aqa-tests#2137 (comment)?

@llxia
Copy link
Contributor Author

llxia commented Jan 11, 2021

Mode150 is disabled on 32bit platforms. It did not run on 32bit hotspot.

@llxia
Copy link
Contributor Author

llxia commented Jan 11, 2021

Target Impl Platform Grinder
sanity.openjdk openj9 x86-64_linux https://ci.adoptopenjdk.net/job/Grinder_TKG/99
sanity.openjdk hotspot x86-64_linux https://ci.adoptopenjdk.net/job/Grinder_TKG/100
sanity.openjdk hotspot x86-32_windows https://ci.adoptopenjdk.net/job/Grinder_TKG/101
sanity.openjdk openj9 x86-32_windows https://ci.adoptopenjdk.net/job/Grinder_TKG/102
sanity.openjdk hotspot x86-64_windows https://ci.adoptopenjdk.net/job/Grinder_TKG/103
sanity.openjdk openj9 x86-64_windows https://ci.adoptopenjdk.net/job/Grinder_TKG/104
sanity.openjdk openj9 x86-64_windows_xl https://ci.adoptopenjdk.net/job/Grinder_TKG/106

@llxia
Copy link
Contributor Author

llxia commented Jan 11, 2021

With this PR, tests with Mode150/Mode650 only will not run on 32bit. The plan is to add a new NoOptions mode to run on 32bit only (in another PR).

@llxia llxia marked this pull request as ready for review January 11, 2021 23:07
@llxia llxia requested a review from smlambert January 11, 2021 23:08
@smlambert smlambert added this to the January 2021 milestone Jan 12, 2021
@smlambert smlambert merged commit 5bc6d62 into adoptium:master Jan 12, 2021
@karianna karianna added the bug Something isn't working label Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants