x-select: set value to null, not undefined, for no selection

`Ember.computed.alias` treats `undefined` specially, causing some writes to fail.
adopted-ember-addons · Jun 28, 2015 · 2e4b88d · 2e4b88d
1 parent 539a041
commit 2e4b88d
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/addon/components/x-select.js b/addon/components/x-select.js
@@ -156,7 +156,7 @@ export default Ember.Component.extend({
     if (option) {
       this.set('value', option.get('value'));
     } else {
-      this.set('value', undefined);
+      this.set('value', null);
     }
   },
 

diff --git a/tests/acceptance/x-select-single-blockless-option-value-test.js b/tests/acceptance/x-select-single-blockless-option-value-test.js
@@ -89,7 +89,7 @@ describe('XSelect: Single Selection Blockless w/ Option Value', function() {
       this.$().prop('selectedIndex', 4).trigger('change');
     });
     it("has no value", function() {
-      expect(controller.get('tagged')).to.equal(undefined);
+      expect(controller.get('tagged')).to.equal(null);
     });
   });
 

diff --git a/tests/acceptance/x-select-single-blockless-test.js b/tests/acceptance/x-select-single-blockless-test.js
@@ -84,7 +84,7 @@ describe('XSelect: Single Selection Blockless', function() {
       this.$().prop('selectedIndex', 4).trigger('change');
     });
     it("has no value", function() {
-      expect(controller.get('tagged')).to.equal(undefined);
+      expect(controller.get('tagged')).to.equal(null);
     });
   });
 

diff --git a/tests/acceptance/x-select-single-test.js b/tests/acceptance/x-select-single-test.js
@@ -79,7 +79,7 @@ describe('XSelect: Single Selection', function() {
       this.$().prop('selectedIndex', 4).trigger('change');
     });
     it("has no value", function() {
-      expect(controller.get('tagged')).to.equal(undefined);
+      expect(controller.get('tagged')).to.equal(null);
     });
   });