Merge pull request #41 from offirgolan/format-match

[BUGFIX] Use String.match instead of RegExp.test to support g flag

addon/format.js

@@ -13,6 +13,7 @@ const {
   isEmpty,
   assert,
   deprecate,
+  canInvoke,
   getProperties
 } = Ember;
 
@@ -68,7 +69,7 @@ export default function validateFormat(value, options, model, attribute) {
     set(options, 'regex', regex);
   }
 
-  if (regex && !regex.test(value)) {
+  if (!canInvoke(value, 'match') || (regex && isEmpty(value.match(regex)))) {
     return validationError(type || 'invalid', value, options);
   }
 

tests/unit/validators/format-test.js

@@ -60,6 +60,9 @@ test('email', function(assert) {
     '[email protected]'
   ];
   let invalidAddresses = [
+    null,
+    undefined,
+    404,
     'plainaddress',
     '#@%^%#$@#$@#.com',
     '@domain.com',
@@ -170,17 +173,39 @@ test('url', function(assert) {
 });
 
 test('custom', function(assert) {
-  assert.expect(2);
+  assert.expect(3);
 
   options = {
     regex: /^(?=.*\d)(?=.*[a-z])(?=.*[A-Z]).{4,8}$/
   };
 
   options = cloneOptions(options);
 
+  result = validate(null, options);
+  assert.equal(processResult(result), 'This field is invalid');
+
   result = validate('password', options);
   assert.equal(processResult(result), 'This field is invalid');
 
   result = validate('Pass123', options);
   assert.equal(processResult(result), true);
 });
+
+test('custom with g flag', function(assert) {
+  assert.expect(3);
+
+  options = {
+    regex: /foo/g
+  };
+
+  options = cloneOptions(options);
+
+  result = validate('foo', options);
+  assert.equal(processResult(result), true);
+
+  result = validate('foo', options);
+  assert.equal(processResult(result), true);
+
+  result = validate('bar', options);
+  assert.equal(processResult(result), 'This field is invalid');
+});