Bug: updated tests

[MelSumner]

This will end up being a major because we had to bump the node version.

Changes:

• updated the package.json file so the scripts were sorted alphabetically.
• consolidated node versions to latest LTS
• updated specific dependencies
• removed the 3.25 scenario
• moved from testdouble to sinon

Everything is passing locally but not here, so I think we need to figure out what must pass to get the next release out, and then what needs to be fixed after that.

[knownasilya]

Would this be a major version change since the node version is being updated?

[MelSumner]

@knownasilya we might need to make it one.

I'm trying to get the tests to pass and only upgrading what I need to do, in order to make that happen. WDYT?

[knownasilya]

I'm fine with bumping a major, plenty of numbers to go around. It'll be an easy upgrade if that's the only change. Looks like the GH actions workflow is busted too.

[MelSumner]

ok I'll look at that too. Do you think it wants a specific version number of Node or is =>16 type of change good enough?

[MelSumner]

Yeah, I just looked at it and I have no idea why. It looks like it should be fine?

[MelSumner]

ok reverting the node change worked, but it looks like it is trying to test against 3.25 which I think we should just make it 3.28 or higher for this one.
Would that also mean a major? not sure.

[knownasilya]

Yes a major would be required for that. Probably need to upgrade node for CI too.

[ef4]

I also don't see why these tests were passing before, but I think the fix here won't last. Once the month rolls over they would start failing again.

Here is an alternative solution that I think will be more permanent: ef4@04437ab

[knownasilya]

Nice @MelSumner

[mansona]

Looks good to me 🎉