Use luxon #519
Open
Use luxon #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @robinvrd! Thank you for your work! Wondering, could it be config option to use? Instead of dropping of moment-js just replacing moment to luxon looks like huge breaking change, and that's MR is not merged or reviewed (likely)
|
IBRAHIMDANS
reviewed
Aug 22, 2023
| @theme="dark-theme" | ||
| @onSelection={{action "doSomethingWithSelectedValue"}} | ||
| <PikadayInput | ||
| @format="cccc LLLL d yyyy, h:mm:ss a" |
| <PikadayInput | ||
| @value={{this.startDate}} | ||
| @onSelection={{action (mut this.startDate)}} | ||
| @format="dd.LL.yyyy" |
| @@ -172,7 +174,7 @@ module('Integration | Component | pikaday-input', function(hooks) { | |||
|
|
|||
| test('format of the input is changeable', async function(assert) { | |||
| this.set('value', new Date(2010, 7, 10)); | |||
| this.set('format', 'YYYY.DD.MM'); | |||
| this.set('format', 'yyyy.dd.LL'); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Althought moment.js works well with pikaday.js, it is now deprecated and has to be replaced with an alternative like
luxon(basically its successor from same team).Packages installation
ember-auto-import(andwebpack) were necessary to useluxontestdoublewas causing troubles withwebpackand its use was pretty basic (so replaceable)ember-cli-babelwas causing issues withwebpackChanges
luxonfollows ISO weekdays order so we had to change all aboutfirstDayas Monday is now 0 (and not 1)luxonuses other formatting tokens so we had to change all aboutformat(https://moment.github.io/luxon/docs/manual/formatting.html#table-of-tokens)moment.jsbut not withluxon, we had to use pikaday methodstoStringandparse(https://github.com/Pikaday/Pikaday#formatting)