Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup dependencies #321

Merged
merged 2 commits into from
Apr 15, 2020
Merged

Cleanup dependencies #321

merged 2 commits into from
Apr 15, 2020

Conversation

Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Apr 15, 2020

There were several dev dependencies that we don't actually need since we don't publish our dummy app anywhere.

Turbo87 added 2 commits April 15, 2020 10:27
@Turbo87
package.json: Use caret constraint for eslint dependency
f89a5fc
@Turbo87
Remove unused dev dependencies
80585be 
These dependencies are mostly only needed for addons that publish their dummy app somewhere. We don't do that, so we don't need those dependencies either.
@Turbo87 Turbo87 added the internal maintenance that comes with software label Apr 15, 2020
MelSumner
MelSumner approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! 👍

@MelSumner MelSumner merged commit b3714ba into adopted-ember-addons:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MelSumner MelSumner MelSumner approved these changes

Assignees
No one assigned
Labels
internal maintenance that comes with software
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Turbo87 @MelSumner