Remove jQuery from interactor and components #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FabHof thank you for making this improvement! Could you fix the linting error noted by the CI failure? |
|
Linting error fixed |
ghost
reviewed
Jun 26, 2019
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "ember-pikaday", | |||
| "version": "2.3.1", | |||
| "version": "2.3.2-lessjQuery", | |||
There was a problem hiding this comment.
That should not have been pushed. sorry
|
I think we can remove this line as well: https://github.com/adopted-ember-addons/ember-pikaday/blob/master/package.json#L26 |
lifeart
reviewed
Jun 26, 2019
addon/components/pikaday-input.js
Outdated
| if (this.get('pikaday').getDate() === null || isEmpty(this.$().val())) { | ||
| if ( | ||
| this.get('pikaday').getDate() === null || | ||
| isEmpty(this.get('element.value')) |
There was a problem hiding this comment.
this.elment = dom element, don't think we can access dom properties using ember getter.
this.get('element').value
lifeart
approved these changes
Jun 27, 2019
|
@FabHof give we modified the |
ghost
merged commit 
ghost
mentioned this pull request
ghost
mentioned this pull request
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #219