Add Chips to paper-menu branch #501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This probably needs a rebase. |
…mber-power-select)
…ectly Angular Material's styles for contact chips expect the chips to be within an md-chips tag inside the md-contact-chips tag.
The "remove" buttons in chips were default paper-icon size (24), which is too big to fit nicely in the chips. 18 seems about right.
…paper-autocomplete
Bottom border is now visible and changes colour depending on focus.
Allows for keyboard navigation of existing chips, including removal. This doesn't (yet) extend to contact chips.
Make contact chips keyboard navigable by extending chips.
This allows for regular chips to use autocomplete, optionally allowing the user to add their own values in addition to those offered by autocomplete.
… require match Both demos had requireMatch=true; only the second should have had it.
Requires paper-autocomplete to fire onBlur events (see PR adopted-ember-addons#504)
|
@miguelcobain Rebased, with a few niggling little issues fixed. I think the behaviour should now match AM's, though I might have missed some edge cases somewhere. |
39 tasks
|
Closing - replaced by #527 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in PR #344, this is a rebase and continuation of @mansona's work on implementing Chips. It uses the new ember-power-select based paper-autocomplete from PR #395 for Contact Chips and chips with autocomplete, and enables keyboard navigation.