-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Autocomplete #132
Conversation
@peec Thanks for the initiative! Looks like we have a dependency on the progress-linear component, right? Suggestion:
@mike1234 and I talked a bit, and we both agreed in merging both projects. So this means good news! |
Yep, you are correct, the autocomplete component uses progress linear for e.g. ajax requests in autocomplete to show loading of items
I will submit a separate branch based on ember-material-design's progress component
This is very good news! Glad you figured this one out! +1 |
…pect to angular version.
…uery's jQuery.getJSON etc. Simple callback can be passed which should return a promise.
…ng. Demos + docs for everything as well. Now just some refactoring left.
… autocomplete suggestions is shown - just like angular material this is also in a service.
@miguelcobain Autocomplete is now done in terms of functionality based on angular's. I dumped a demo on http://jensb.home.pkj.no/paper-autocomplete/index.html#/autocomplete . The "Promise of data (Ember data)" section loading doesn't work because the component is commented until #134 is merged |
…use new constants service.
…tive ( and possibly allow to override other things in the future). Remove unessecary class from paper-progress-linear.
…nstead. Less code, more power of ember.
…ding template for it ). Also cleanups
@miguelcobain I think I am quite happy with the autocomplete feature as it stands right now. You may take a look at this PR when you have time. The components have tests, and are all decoupled as much as possible which makes it really flexible for further enhancements or features if we wish so. New componentsThe PR consist of these new compoenets:
DependenciesFurthermore, the paper-autocomplete component also take use of these components behind the scenes:
New service: utilThere is also a new service (util) that is directly converted from angular material. We use two methods in the util service: DocumentationI wrote the documentation on the components page, there are plenty of examples and a table explaining all the possible attributes. |
@miguelcobain How is it going on the merge ? |
@peec Not really sure why github didn't close this. Your commits are there. |
Adds Autocomplete feature to ember-paper as of:
This is a rewrite of the angular autocomplete but with heavy usage of ember principles, which means cleaner code and a lot nicer code base ( i think ).
Current task list: