-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ember-in-viewport #674
Update ember-in-viewport #674
Conversation
no issue - bumps `ember-in-viewport` too `3.2.2` - adds a fix for passing non-existent selectors to `ember-in-viewport` when there is no fixed header/footer and therefore no `.lt-scrollable` element
closes TryGhost/Ghost#10521 - bumped `ember-in-viewport` and `ember-infinity` which fixed the Safari bug - forced resolution of `ember-in-viewport` to 3.2.2 to avoid conflicts across project sub-dependencies - switched to fork of `ember-light-table` which contains a compatibility fix with `[email protected]` (PR'd here adopted-ember-addons/ember-light-table#674)
Hey. Thanks for this. The reasoning behind the change looks 👍
|
Could it possibly be b/c of this class syntax in this service in 2.12? https://github.com/DockYard/ember-in-viewport/blob/master/addon/services/-observer-admin.js#L16 |
Any updates here? I think if we wanted to upgrade here, we should update ember-light-table && it's travis config. |
Closing in favour of #693 @kevinansfield I've pulled this into the work their which will include bumping the in-viewport version to 3.5.5 and adding a failing test case plus fix for the non-existent selectors thing you've raised here if it is still an issue. Thanks for you contribution! |
no issue
ember-in-viewport
too3.2.2
ember-in-viewport
as occurs when there is no fixed header/footer and therefore no.lt-scrollable
elementThis was a necessary upgrade for us because the pinned version of
ember-in-viewport
has a bug in Safari that was causing our other uses of{{ember-infinity}}
to fail. Upgrading the version ofember-in-viewport
in our app (and forcing resolution via package.json) ran into thescrollableArea
bug that is also fixed in this PR.