-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Column.js to support parent #348
Merged
offirgolan
merged 8 commits into
adopted-ember-addons:master
from
alexander-alvarez:parent-col-ref
Mar 1, 2017
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1139a98
Update Column.js to support parent
alexander-alvarez 3160679
adding test
alexander-alvarez b1e99ec
Merge branch 'master' into parent-col-ref
alexander-alvarez cbd50f8
Updating _group to be parent, adding docs
alexander-alvarez e9f8acf
Merge branch 'master' into parent-col-ref
alexander-alvarez dd3f0fa
Fixing Brackets
alexander-alvarez d44ae91
Remove unused dereference
alexander-alvarez 7ff100a
_group should be replaced by parent
alexander-alvarez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexander-alvarez
'dragColumnGroup'
should be'parent'
for both here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's the same thing.
I was going off of the comment:
A column is a valid drop target only if its in the same group
, so decided to use the variable that had the word group in it, instead of parent.dragColumnGroup
is derived fromparent
, so if parent's are equal, then thedragColumnGroup
will be equal, and if no parents are defined:null === null
will be truthy just asthis.get('table.columns') === this.get('table.columns')
is.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right but the
dragColumnGroup
exists on the column component not the column instance. You are currently always comparingundefined
toundefined
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup... I'm going to show myself the door... so off these days man...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL its all good! I got you 😄