Support cell and column types #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Released v1.0.0-beta.2 Update changelog Move ember-wormhole as a dependency Released v1.0.0-beta.1 Fixes to table scroll mixin and code cleanup (#17) # Conflicts: # CHANGELOG.md # package.json
* master: Released v1.0.0-beta.4 fix overflow issue Update docs for row constructor Released v1.0.0-beta.3 Custom class names + Hide row (#25)
* master: Update all dependencies 🌴 (#26)
|
ping @thoov. What do you think about this feature? It allows us and users to create cell and column 'types' which should extend from the base. This allows for the possibility of creating draggable columns, link-to cells, etc. |
| @@ -1,3 +1,7 @@ | |||
| {{#each columns as |column|}} | |||
| {{lt-cell column=column row=row rawValue=(get row column.valuePath) tableActions=tableActions}} | |||
| {{component (concat 'light-table/cells/' column.cellType) | |||
| column=column | |||
There was a problem hiding this comment.
This is a minor thing but instead of column=column and row=row you might want to look into positionalParams
|
@offirgolan I think this looks good! Do you have an example written up yet (aka on your demo page)? |
* master: Use Trackpad Scroll Emulator for better scrollbars (#32) # Conflicts: # addon/components/light-table.js # addon/templates/components/lt-body.hbs
offirgolan
added a commit
that referenced
this pull request
Jun 8, 2016
HenryVonfire
pushed a commit
to HenryVonfire/ember-light-table
that referenced
this pull request
Jun 27, 2016
* Auto setup scroll container for fixed header/footer and code cleanup * Add debounce in table scroll event. Cleanup demo app * Update changelog * Upgrade dependencies * Support custom class names * Add hidden property to row class * Update changelog * Add support for cell and column types * Add blueprints and some refactoring * Fix docs * rename headerComponent to component * remove ember import from blueprints * Refactoring and overwrite for body
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.