[FEATURE] multiSelectRequiresKeyboard option for toggling row selec…
#160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion without ctrl/cmd shift-click to select multiple intervening rows works as always
| @@ -24,7 +24,7 @@ test('it renders', function(assert) { | |||
| assert.equal(this.$().text().trim(), ''); | |||
| }); | |||
|
|
|||
| test('row selection', function(assert) { | |||
| test('row selection - enable or disable', function(assert) { | |||
There was a problem hiding this comment.
rather than have three tests called 'row selection' I took the liberty of adding additional detail to these test names to differentiate them
|
@bargar thank you for taking the time in putting this together. Overall, I think the PR looks great! I really appreciate the extra test cases 😸 Before I merge this, I'd like to pull your branch just so I can get a feel for the feature. I'll prolly do that after this long weekend and we can go from there! |
Gorzas
pushed a commit
to Gorzas/ember-light-table
that referenced
this pull request
Sep 8, 2016
…tion without ctrl/cmd (adopted-ember-addons#160) shift-click to select multiple intervening rows works as always
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ction without ctrl/cmd
shift-click to select multiple intervening rows works as always
As discussed in #147.