Code

API Design#135

Code

Merged

lukemelia merged 45 commits intomasteradopted-ember-addons/ember-keyboard:masterfrom rfc/api-changeadopted-ember-addons/ember-keyboard:rfc/api-changeCopy head branch name to clipboardJun 4, 2020

+6,532-1,375

Commits

Commits on Jun 3, 2020

• The beginning of an API Design doc

  lukemelia

  committed
  26d6ad4

  Copy full SHA for 26d6ad4

• Added another proposal

  lukemelia

  committed
  615eec9

  Copy full SHA for 615eec9

• Update API-DESIGN based on feedback from @mattmcmanus

  lukemelia

  committed
  b655029

  Copy full SHA for b655029

• Add Proposal 4, which incorporates community feedback

  Show description for a535680
  lukemelia

  committed
  a535680

  Copy full SHA for a535680

• Incorporate low-level API idea and sections on sequences and migration

  lukemelia

  committed
  e681070

  Copy full SHA for e681070

• Remove proposals 1 to 3 and prepare to finalize API doc

  lukemelia

  committed
  0d6b5ea

  Copy full SHA for 0d6b5ea

• Deprecate keyboard-press component in favor of new on-key helper

  Show description for 8747846
  lukemelia

  committed
  8747846

  Copy full SHA for 8747846

• WIP start implementing the on-key helper

  lukemelia

  committed
  a5541a0

  Copy full SHA for a5541a0

• on-key modifier replaces on-keyboard and keyboard-shortcut

  Show description for 2198732
  lukemelia

  committed
  2198732

  Copy full SHA for 2198732

• Pass event to on-key callback when possible

  lukemelia

  committed
  c67745f

  Copy full SHA for c67745f

• Fix a mistake in API-DESIGN doc

  lukemelia

  committed
  6872a30

  Copy full SHA for 6872a30

• Continue to flesh out API Design doc with info about existing ember-keyboard features

  lukemelia

  committed
  a6053ee

  Copy full SHA for a6053ee

• Add note about _all to API-DESIGN.md

  lukemelia

  committed
  6046d96

  Copy full SHA for 6046d96

• Document planned new responder API in API-DESIGN.md

  lukemelia

  committed
  e89fc98

  Copy full SHA for e89fc98

• Initial implementation of isKey

  lukemelia

  committed
  41fd677

  Copy full SHA for 41fd677

• Allow listenerName(type, keyArray) to accept a string as a second argument

  Show description for c84803d
  lukemelia

  committed
  c84803d

  Copy full SHA for c84803d

• Add support for new responder API

  Show description for 0bc839c
  lukemelia

  committed
  0bc839c

  Copy full SHA for 0bc839c

• Update on-key helper and modifier to use the new responder API

  lukemelia

  committed
  dcdab6b

  Copy full SHA for dcdab6b

• Verify support for calling stopPropagation() and stopImmediatePropagation() in context of new responder APIs

  lukemelia

  committed
  5c710da

  Copy full SHA for 5c710da

• Convert keyboard service to use a Set for registeredResponders

  Show description for f80f146
  lukemelia

  committed
  f80f146

  Copy full SHA for f80f146

• Simplify event listener in service using @action decorator

  lukemelia

  committed
  6886bf7

  Copy full SHA for 6886bf7

• Add some polyfills to get modifiers working in Ember 3.8

  lukemelia

  committed
  bbc8b5a

  Copy full SHA for bbc8b5a

• Deprecate the initializer.

  lukemelia

  committed
  af7c42f

  Copy full SHA for af7c42f

• Adapt EKMixin to new responder API.

  Show description for 1d3db6d
  lukemelia

  committed
  1d3db6d

  Copy full SHA for 1d3db6d

• Add if-key helper.

  Show description for e46762f
  lukemelia

  committed
  e46762f

  Copy full SHA for e46762f

• Add support to isKey for _all as a special key combo

  Show description for 3fb20f2
  lukemelia

  committed
  3fb20f2

  Copy full SHA for 3fb20f2

• Ignore case while matching modifier strings

  lukemelia

  committed
  8b4cdfc

  Copy full SHA for 8b4cdfc

• Add handling of cmd modifier to isKey.

  Show description for 5343a27
  lukemelia

  committed
  5343a27

  Copy full SHA for 5343a27

• Simplify trigger-event util by leveraging keyboard-listener parsing

  lukemelia

  committed
  505b4df

  Copy full SHA for 505b4df

• Update test for changed key-matching behavior and write a section of API-DESIGN.md suitable for future use in an upgrade guide.

  lukemelia

  committed
  3a41db8

  Copy full SHA for 3a41db8

• Remove unused code and simplify

  lukemelia

  committed
  f82c562

  Copy full SHA for f82c562

• Add support for special case matching of keys transformed by modifiers

  lukemelia

  committed
  01c0262

  Copy full SHA for 01c0262

• Shorten deprecation ID for initializer

  lukemelia

  committed
  b291c46

  Copy full SHA for b291c46

• Fix lint errors

  lukemelia

  committed
  967319e

  Copy full SHA for 967319e

• Update depedencies: e-compatibilty-helpers, e-cli-update, e-template-lint,eslint-*, markdown-code-highlighting, qunit-dom

  lukemelia

  committed
  136a6fc

  Copy full SHA for 136a6fc

• Update ember-source and friends

  lukemelia

  committed
  e49ad56

  Copy full SHA for e49ad56

• Remove IE 11 from targets.js

  lukemelia

  committed
  fda7076

  Copy full SHA for fda7076

• Remove some unneeded dependencies

  lukemelia

  committed
  8fc3024

  Copy full SHA for 8fc3024

• Added an assertion that the on-key helper is invoked with a functio

  lukemelia

  committed
  ff71f27

  Copy full SHA for ff71f27

• Implement decorators as new JS API, and deprecate mixins.

  Show description for 674a447
  lukemelia

  committed
  674a447

  Copy full SHA for 674a447

• Move jsconfig.json to proper location

  lukemelia

  committed
  e1a1ae9

  Copy full SHA for e1a1ae9

• Give decorated key responder class a name

  lukemelia

  committed
  63f0900

  Copy full SHA for 63f0900

• Fix lint errors

  lukemelia

  committed
  9f262d5

  Copy full SHA for 9f262d5

• Update tests and docs to reflect that decorators require Ember 3.10 and higher

  lukemelia

  committed
  6dd644f

  Copy full SHA for 6dd644f

• Add an upgrade guide

  Show description for 09f7a0a
  lukemelia

  committed
  09f7a0a

  Copy full SHA for 09f7a0a