Revert @ember/test-helpers update and pin to 2.7.0 #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilest
force-pushed
the
fix/pin-test-helpers
branch
from
aa239be to
d879aca
Compare
And pin to 2.7.0 along with types to 2.6.0.
gilest
force-pushed
the
fix/pin-test-helpers
branch
from
d879aca to
42d9639
Compare
gilest
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary measure.
Don't really want to release while this dependency is pinned with a
~as it will pass this on to consuming apps.But also uncomfortable with the CI failing for ember 3.28.
Reference:
emberjs/ember-test-helpers/issues/1232