Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lengthComputable: false event to progress unit tests #1021

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Add lengthComputable: false event to progress unit tests #1021

merged 1 commit into from
Nov 13, 2023

Conversation

mkszepp
Copy link
Contributor

@mkszepp mkszepp commented Nov 13, 2023 •
edited
Loading

Small test improvement #1017

@mkszepp
Copy link
Contributor Author

mkszepp commented Nov 13, 2023

@gilest added the test, which i have requested here. https://github.com/adopted-ember-addons/ember-file-upload/pull/1017/files/8a7df717bc86f44f353c22bb7783cf0bf1a5b6e2#diff-a23df8d61fe0731e46a5646bc9b1b2df2648b8c51dbc757896380b7eae9a70f4R124

@gilest
Copy link
Collaborator

gilest commented Nov 13, 2023

Nice - thanks

@gilest gilest changed the title Add progress test for lengthComputable: false Add lengthComputable: false event to progress unit tests Nov 13, 2023
@gilest gilest merged commit af05180 into adopted-ember-addons:master Nov 13, 2023
14 checks passed
@mkszepp mkszepp deleted the improve-progress-test branch November 13, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilest gilest gilest approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkszepp @gilest