The latest published build breaks TypeScript apps

[andreyfel]

Updating from 8.3.1 to 8.4.0 breaks linting in our app as it starts thinking that getOwner returns any.
The root cause of this are these comments added to published type declarations:

/// <reference types="ember-source/types/stable/@ember/owner/index" />
/// <reference types="ember-source/types/stable/@ember/controller/owner-ext" />
/// <reference types="ember-source/types/stable/@ember/routing/owner-ext" />
/// <reference types="ember-source/types/stable/@ember/service/owner-ext" />

https://www.npmjs.com/package/ember-file-upload/v/8.4.0?activeTab=code

Here is the relevant ticket in TypeScript repo:
microsoft/TypeScript#56571

Not sure what the addon authors should do about it.

• Manually delete those /// comments before publishing?
• Rollback Typescript to 5.2?
• Wait until ember core team gives a recommendation?

I saw a discussion in Discord in dev-typescript channel but it hasn't resolved into any recommendations so far.

[andreyfel]

Recommendation from @NullVoxPopuli

If you're building the library, you can either downgrade typescript or use a post-build script to remove the triple slash reference lines before publish.

[NullVoxPopuli]

Related:

• Fix triple-slash reference in complied output, breaking TS consumers tracked-tools/ember-async-data#704
• Fix triple-slash reference in complied output tracked-tools/ember-async-data#705 (comment)
• Remove reference to EmberComponent to remove the triple-slash directive tildeio/ember-element-helper#113
• Types are incorrecly published and reference the ember-source built in preview types (which do not exist in sufficiently new enough projects) tildeio/ember-element-helper#111
• Fix Glint types by converting helpers to plain functions jmurphyau/ember-truth-helpers#188

A work around:

 "build:types": "glint --declaration && grep -r -l '///' declarations/ | sort | uniq | xargs perl -e \"s/\\/\\/\\/.*$//\" -pi",

In package.json

[gilest]

Ahh change management in typescript is frustrating.

I was confident in releasing after this upgrade because we run type-checking in CI (for TS 5.0, 5.1, 5.2, 5.3). This issue does not fail those typechecks 😢

Any ideas how I can add regression coverage for this?

The Owner type is used in an internal modifier that's mounted in FileDropzone. But we have integration tests working out that component...

Do I need to import or use the Owner type elsewhere in the tests?

[gilest]

Rollback released in 8.4.1

[NullVoxPopuli]

Any ideas how I can add regression coverage for this?

add type-checking to the scenario testing

Do I need to import or use the Owner type elsewhere in the tests?

this is what ember-resources does: https://github.com/NullVoxPopuli/ember-resources/blob/f0a8b8506257add362e84dad49af8ec9218c8a66/ember-resources/src/core/function-based/manager.ts#L27-L37

Do I need to import or use the Owner type elsewhere in the tests?

you could possible cast to any or drop support for ember versions that don't have the Owner type.

[NullVoxPopuli]

Made a tool to help out in the future: https://github.com/NullVoxPopuli/fix-bad-declaration-output