Skip to content

Commit

Permalink
Add CI matrix to type-check TypeScript versions (#996)
Browse files Browse the repository at this point in the history
Also adds "TypeScript 5 and above" to the Compatibility section of the readme. This is an indication based off what passed in CI.

We haven't yet adopted an official support policy for TypeScript.
  • Loading branch information
gilest authored Sep 19, 2023
1 parent b157d50 commit 7a7d393
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 2 deletions.
20 changes: 18 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,18 @@ jobs:
run: pnpm --filter test-app test:ember --launch chrome

typecheck:
name: Typecheck
name: 'Typecheck ${{ matrix.typescript-scenario }}'
runs-on: ubuntu-latest
needs: lint
continue-on-error: true
strategy:
fail-fast: true
matrix:
typescript-scenario:
- [email protected]
- [email protected]
- [email protected]

steps:
- uses: actions/checkout@v4
with:
Expand All @@ -79,8 +88,15 @@ jobs:
- name: 'Install dependencies'
run: pnpm install --frozen-lockfile

- name: 'Change TS to ${{ matrix.typescript-scenario }}'
run: 'pnpm add --save-dev ${{ matrix.typescript-scenario}}'
working-directory: ./test-app

- name: Lint
run: pnpm --filter test-app lint:types
run: |
pnpm --filter "test-app*" exec tsc -v;
pnpm --filter "test-app*" exec glint --version;
pnpm --filter "test-app*" lint:types;
floating-dependencies:
name: Tests - Floating Dependencies
Expand Down
1 change: 1 addition & 0 deletions ember-file-upload/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Uploads can be managed through queues and continue in the background, even after
## Compatibility

* Ember.js 3.25 or above
* TypeScript 5.0 or above
* ember-auto-import 2.0 or above
* Ember CLI v2.13 or above
* Node.js v16 or above
Expand Down

0 comments on commit 7a7d393

Please sign in to comment.