-
-
Notifications
You must be signed in to change notification settings - Fork 118
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add CI matrix to type-check TypeScript versions (#996)
Also adds "TypeScript 5 and above" to the Compatibility section of the readme. This is an indication based off what passed in CI. We haven't yet adopted an official support policy for TypeScript.
- Loading branch information
Showing
2 changed files
with
19 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,9 +59,18 @@ jobs: | |
run: pnpm --filter test-app test:ember --launch chrome | ||
|
||
typecheck: | ||
name: Typecheck | ||
name: 'Typecheck ${{ matrix.typescript-scenario }}' | ||
runs-on: ubuntu-latest | ||
needs: lint | ||
continue-on-error: true | ||
strategy: | ||
fail-fast: true | ||
matrix: | ||
typescript-scenario: | ||
- [email protected] | ||
- [email protected] | ||
- [email protected] | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
with: | ||
|
@@ -79,8 +88,15 @@ jobs: | |
- name: 'Install dependencies' | ||
run: pnpm install --frozen-lockfile | ||
|
||
- name: 'Change TS to ${{ matrix.typescript-scenario }}' | ||
run: 'pnpm add --save-dev ${{ matrix.typescript-scenario}}' | ||
working-directory: ./test-app | ||
|
||
- name: Lint | ||
run: pnpm --filter test-app lint:types | ||
run: | | ||
pnpm --filter "test-app*" exec tsc -v; | ||
pnpm --filter "test-app*" exec glint --version; | ||
pnpm --filter "test-app*" lint:types; | ||
floating-dependencies: | ||
name: Tests - Floating Dependencies | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters