Update to electron-forge 6 & simplify build pipeline/project structure

.appveyor.yml

@@ -6,9 +6,8 @@ environment:
     - nodejs_version: "8"
 
 cache:
-  - '%APPDATA%\npm-cache -> package.json' # Only load this from cache if package.json is unchanged
+  - '%APPDATA%\npm-cache -> yarn.lock' # Only load this from cache if yarn.lock is unchanged
   - '%LOCALAPPDATA%\Yarn'
-  - '%USERPROFILE%\.electron'
 
 install:
   - ps: Install-Product node $env:nodejs_version $env:platform
@@ -18,3 +17,7 @@ test_script:
   - yarn test
 
 build: off
+
+# we don't do anything different between branch and PR builds, so let's not
+# redundantly run both when a PR is open
+skip_branch_with_pr: true

.eslintrc.js

@@ -26,8 +26,7 @@ module.exports = {
     'processNode': true
   },
   rules: {
-    'ember/no-jquery': 'error',
-    'no-console': 'off'
+    'ember/no-jquery': 'error'
   },
   overrides: [
     // node files
@@ -60,10 +59,37 @@ module.exports = {
       rules: Object.assign({}, require('eslint-plugin-node').configs.recommended.rules, {
         // add your custom rules and overrides for node files here
         'ember/avoid-leaking-state-in-ember-objects': 'off',
-        'node/no-unpublished-require': ['error', {
-          'allowModules': ['ember-cli']
+      })
+    },
+    // forge template files
+    {
+      files: [
+        'forge/files/**/*.js'
+      ],
+      env: {
+        browser: false,
+        node: true
+      },
+      plugins: ['node'],
+      rules: Object.assign({}, require('eslint-plugin-node').configs.recommended.rules, {
+        'node/no-missing-require': ['error', {
+          'allowModules': [
+            'electron',
+            'ember-electron'
+          ],
         }]
       })
+    },
+    // mocha files
+    {
+      files: [
+        'node-tests/**/*.js'
+      ],
+      env: {
+        browser: false,
+        node: true,
+        mocha: true
+      }
     }
   ]
 };

.gitignore

@@ -3,7 +3,6 @@
 # compiled output
 /dist/
 /tmp/
-/electron-out/
 
 # dependencies
 /bower_components/

.mocharc.js

@@ -0,0 +1,3 @@
+module.exports = {
+  file: [ 'node-tests/helpers/test-setup' ]
+};

.npmignore

@@ -21,7 +21,6 @@
 /bower.json
 /config/ember-try.js
 /dist
-/electron-out
 /CONTRIBUTING.md
 /ember-cli-build.js
 /tmp

.travis.yml

@@ -2,7 +2,7 @@ language: node_js
 node_js:
   # we recommend testing addons with the same minimum supported node version as Ember CLI
   # so that your addon works for all apps
-  - "10"
+  - "8"
 
 sudo: false
 dist: trusty
@@ -37,7 +37,7 @@ jobs:
     - env: EMBER_TRY_SCENARIO=ember-canary
 
   include:
-    # runs linting and fast integration/unit tests
+    # runs linting and fast tests
     - stage: "Basic Tests"
       script:
         - yarn lint:hbs
@@ -51,16 +51,6 @@ jobs:
       env: END_TO_END_TESTS=yarn
     - env: END_TO_END_TESTS=npm
 
-    # Define the release stage that runs semantic-release
-    - stage: "Release"
-      node_js: lts/*
-      script: skip
-      deploy:
-        provider: script
-        skip_cleanup: true
-        script:
-          - npx semantic-release
-
 before_install:
   - yarn config set no-progress
 

README.md

@@ -18,15 +18,7 @@ Documentation
 
 Ember-Electron is a small open source project. Use [GitHub Issues](https://github.com/adopted-ember-addons/ember-electron/issues) to report bugs and errors within the addon.
 
-If you need help *using* the addon with your application, may we recommend the excellent Ember community? You can the [various places to get help here](https://www.emberjs.com/community/). If you have questions regarding Electron, their [Slack and forum](https://electron.atom.io/contact/) will be helpful as well.
-
-
-## Development
-
-`ember-electron` uses [Semantic Release](https://github.com/semantic-release/semantic-release) to
-automate the whole release process. In order to have a PR merged, please ensure that your PR
-follows the commit guidelines so that our robots can understand your change. This repository uses
-the [`conventional-changelog` rules from the `eslint` repository](https://github.com/conventional-changelog/conventional-changelog/tree/master/packages/conventional-changelog-eslint).
+If you need help *using* the addon with your application, may we recommend the excellent Ember community? You can check out the [various places to get help here](https://www.emberjs.com/community/). In particular, the [Ember community Discord](https://discordapp.com/invite/emberjs) has a `#topic-desktop` channel which is a great place to ask questions about `ember-electron`. If you have questions regarding Electron, their [Slack and forum](https://electron.atom.io/contact/) will be helpful as well.
 
 
 ## Authors

blueprints/ember-electron/files/testem-electron.js

@@ -1,4 +1,3 @@
-/* eslint-env node */
 module.exports = {
   test_page: 'tests/index.html?hidepassed',
   disable_watching: true,
@@ -16,10 +15,9 @@ module.exports = {
       // Note: Some these Chrome options may not be supported in Electron
       // See https://electronjs.org/docs/api/chrome-command-line-switches
       ci: [
-        // --no-sandbox may be needed when running inside a container
+        // --no-sandbox is needed when running Chrome inside a container
         process.env.CI ? '--no-sandbox' : null,
         '--headless',
-        '--disable-gpu',
         '--disable-dev-shm-usage',
         '--disable-software-rasterizer',
         '--mute-audio',