fix: prevent You attempted to update _tracking on Tag issue on Ember-data 4.5+ #482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised we had an issue on, that I reproduce pretty easily in my app with Ember-data 4.6.
The RecordState is registered when we create a new Model.
For a classic native model, the RecordState will be build after all the initial value of the attributes have been set.
But with fragments it's the opposite, the RecordState is build first then the attributes are set which result in a duplicate update of the state
This produce the exact same error that you can find on this issue: #427
My fix is based on the RecordDataDefault, I saw they are using
notifyPropertyChange
to notify an attribute has change instead of what we are doing which is using notifyStateChange to say the state of the record has changed