-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Fragment blueprint to use class instead of extend #379
Comments
Gorzas
added a commit
to Gorzas/ember-data-model-fragments
that referenced
this issue
Oct 5, 2020
I know that the original blueprint uses this attribute to know what type of Model will be used when creating them, but I don't know if it's a good practice to use it in an Ember Addon. I've created this commit to delete it in case it isn't necessary. Related adopted-ember-addons#379
@Gorzas I think this is a good idea. It might be worth doing to get it into the 5.0.0 beta release. It might also be better to use the specific import Fragment from 'ember-data-model-fragments/fragment';
export default class <% name %> extends Fragment {
<% attrs %>
} |
@patocallaghan Yes, I think it's better this way. Made the changes 😄. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As Ember team is deprecating EmberObjects and it's recommending to use ES6 classes, I think we can update the Fragment blueprint to follow this syntax:
What do you think? I may leave a PR with my proposal.
The text was updated successfully, but these errors were encountered: