Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warnings are not filled on the validations object #527

Closed
mnifakram opened this issue Aug 16, 2017 · 1 comment · Fixed by #538
Closed

warnings are not filled on the validations object #527

mnifakram opened this issue Aug 16, 2017 · 1 comment · Fixed by #538

Comments

@mnifakram
Copy link

Environment

  • Ember Version: 2.12.0
  • Ember CLI Version:
  • Ember CP Validations Version: 3.4.0

Steps to Reproduce

https://ember-twiddle.com/79f50d8ee340f865d535e809175997f4?openFiles=controllers.application.js%2C

@offirgolan Do you have any idea why warningMessages, isWarning and warning are not set on the {validations} when calling model.validate()?
zidjian257 added a commit to zidjian257/ember-cp-validations that referenced this issue Sep 8, 2017
@zidjian257
fill warnings property on the validations object
ab1b493 
refs adopted-ember-addons#527
@zidjian257 zidjian257 mentioned this issue Sep 8, 2017
Closed
@offirgolan offirgolan mentioned this issue Sep 18, 2017
Merged
2 tasks
@offirgolan
Copy link
Collaborator

Released with v3.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX] Rework Warning Logic adopted-ember-addons/ember-cp-validations
2 participants
@offirgolan @mnifakram